Alfahosting SMS - 6.x-1.1

Test status
StatusResult
Last receivedSun, 02/26/2012 - 14:42:37
Last requestedSun, 02/26/2012 - 14:43:02
Last testedSun, 02/26/2012 - 14:43:20
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.1
ProjectAlfahosting SMS
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 0 minor(s), 1 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
0 minor(s), 1 critical(s), and 2 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandsms_alfahosting.module012
MessageGroupFilenameLineFunctionStatus
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othersms_alfahosting.module82N/A
Use an indent of 2 spaces, with no tabsOthersms_alfahosting.module124N/A
missing space after commaOthersms_alfahosting.module124N/A

All

Test nameMinorCriticalNormal
Expandsms_alfahosting.module012
MessageGroupFilenameLineFunctionStatus
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othersms_alfahosting.module82N/A
Use an indent of 2 spaces, with no tabsOthersms_alfahosting.module124N/A
missing space after commaOthersms_alfahosting.module124N/A