Canpar Shipping Quotes - 6.x-1.x

Test status
StatusResult
Last receivedSun, 02/26/2012 - 08:17:36
Last requestedSun, 02/26/2012 - 08:18:02
Last testedSun, 02/26/2012 - 08:18:17
Test count8
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectCanpar Shipping Quotes
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 10 minor(s), 0 critical(s), and 22 normal(s); [[SimpleTest]]: [MySQL] 20 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
20 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
ExpandCanparUnitTestCase2000
MessageGroupFilenameLineFunctionStatus
array ( 'CanparShipment' => array ( 'ServiceType' => '1', 'Quantity' => '1', 'Unit' => 'L', 'Weight' => '10', 'Origin' => 'M4X1W7', 'Destination' => 'L4Y2N9', 'COD' => '100.00', 'Declared' => '200.00', 'PUT' => 'No', 'ExtraCare' => '1.00', 'ShippingDate' => '2012-02-26', ), 'CanparCharges' => array ( 'BaseRate' => '9.89', 'ExtraCareCharge' => '10.00', 'CODCharge' => '4.50', ), 'TransitTime' => array ( 0 => '1', ), 'EstimatedDeliveryDate' => array ( 0 => '2012-02-28', ), )Debuguc_canpar.test106CanparUnitTestCase->testBaseRate()
SimpleXMLElement::__set_state(array( 'CanparShipment' => SimpleXMLElement::__set_state(array( 'COD' => '100.00', 'Declared' => '200.00', 'Origin' => 'M4X1W7', 'Destination' => 'L4Y2N9', 'ExtraCare' => '1.00', 'PUT' => 'No', 'Quantity' => '1', 'ServiceType' => '1', 'Weight' => '10', 'Unit' => 'L', 'ShippingDate' => '2012-02-26', )), 'CanparCharges' => SimpleXMLElement::__set_state(array( 'BaseRate' => '9.89', 'ExtraCareCharge' => '10.00', 'CODCharge' => '4.50', )), 'TransitTime' => '1', 'EstimatedDeliveryDate' => '2012-02-28', ))Debuguc_canpar.test107CanparUnitTestCase->testBaseRate()
array ( 'weight' => '20.0', 'weight_unit' => 'lb', 'zone' => '1', 'transit_time' => '1', 'transit_time_guaranteed' => 'false', 'estimated_delivery_date' => '2012-02-28', 'base_charge' => '17.39', 'freight_charge' => '17.39', 'net_charge' => '17.39', 'fuel_surcharge_rate' => '15.55', 'fuel_surcharge' => '2.70', 'subtotal_charge' => '20.09', 'on_hst_charge' => '2.61', 'total_charge' => '22.70', )Debuguc_canpar.test189CanparUnitTestCase->testCustomRate()
SimpleXMLElement::__set_state(array( 'rate' => SimpleXMLElement::__set_state(array( '@attributes' => array ( 'weight' => '20.0', 'weight_unit' => 'lb', 'zone' => '1', 'transit_time' => '1', 'transit_time_guaranteed' => 'false', 'estimated_delivery_date' => '2012-02-28', 'base_charge' => '17.39', 'freight_charge' => '17.39', 'net_charge' => '17.39', 'fuel_surcharge_rate' => '15.55', 'fuel_surcharge' => '2.70', 'subtotal_charge' => '20.09', 'on_hst_charge' => '2.61', 'total_charge' => '22.70', ), )), ))Debuguc_canpar.test190CanparUnitTestCase->testCustomRate()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
10 minor(s), 0 critical(s), and 22 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandtests/uc_canpar.test0013
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.test20N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.test79N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test79N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test90N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test95N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test97N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test100N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test103N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test166N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test178N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test180N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test183N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test186N/A
Expanduc_canpar.install001
MessageGroupFilenameLineFunctionStatus
Use the matching Drupal theme functions, not raw HTML.Otheruc_canpar.install24N/A
Expanduc_canpar.module1008
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Otheruc_canpar.module17N/A
put a space between the asterisk and the comment textOtheruc_canpar.module39N/A
put a space between the asterisk and the comment textOtheruc_canpar.module75N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module87N/A
put a space between the asterisk and the comment textOtheruc_canpar.module127N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module208N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module254N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module257N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module258N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtheruc_canpar.module315N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module330N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module331N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module439N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module440N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module441N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module443N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module444N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module445N/A

All

Test nameMinorCriticalNormal
Expandtests/uc_canpar.test0013
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.test20N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.test79N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test79N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test90N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test95N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test97N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test100N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test103N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test166N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test178N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test180N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test183N/A
Use Drupal's format_date(), not PHP's default date().Otheruc_canpar.test186N/A
Leafuc_canpar.admin.inc000
Expanduc_canpar.install001
MessageGroupFilenameLineFunctionStatus
Use the matching Drupal theme functions, not raw HTML.Otheruc_canpar.install24N/A
Expanduc_canpar.module1008
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Otheruc_canpar.module17N/A
put a space between the asterisk and the comment textOtheruc_canpar.module39N/A
put a space between the asterisk and the comment textOtheruc_canpar.module75N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module87N/A
put a space between the asterisk and the comment textOtheruc_canpar.module127N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module208N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module254N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module257N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module258N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtheruc_canpar.module315N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module330N/A
Use an indent of 2 spaces, with no tabsOtheruc_canpar.module331N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module439N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module440N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module441N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module443N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module444N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otheruc_canpar.module445N/A