OG Vocabulary - 6.x-1.x

Test status
StatusResult
Last receivedTue, 10/02/2012 - 10:44:07
Last requestedTue, 10/02/2012 - 10:45:03
Last testedTue, 10/02/2012 - 10:45:38
Test count4
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectOG Vocabulary
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 7 minor(s), 1 critical(s), and 10 normal(s); [[SimpleTest]]: [MySQL] 239 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
239 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafOG vocab access (OgVocabTestCase) [Organic groups vocabulary]23900

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
7 minor(s), 1 critical(s), and 10 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandog_vocab.install202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherog_vocab.install6N/A
There should be no trailing spacesOtherog_vocab.install14N/A
Use update_sql() instead of db_query() in hook_update_N()Otherog_vocab.install58N/A
Use update_sql() instead of db_query() in hook_update_N()Otherog_vocab.install77N/A
Expandog_vocab.module515
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherog_vocab.module208N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module246N/A
Control statements should have one space between the control keyword and opening parenthesisOtherog_vocab.module265N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module265N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module371N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module545N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module572N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module585N/A
The control statement should be on a separate line from the control conditionalOtherog_vocab.module591N/A
put a space between the asterisk and the comment textOtherog_vocab.module607N/A
Format should be * Implementation of hook_foo().Otherog_vocab.module607N/A
Expandog_vocab.services.inc002
MessageGroupFilenameLineFunctionStatus
use a space between the closing parenthesis and the open bracketOtherog_vocab.services.inc51N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.services.inc58N/A
Expandog_vocab.test001
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherog_vocab.test2N/A

All

Test nameMinorCriticalNormal
Leafog_vocab.admin.inc000
Expandog_vocab.install202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherog_vocab.install6N/A
There should be no trailing spacesOtherog_vocab.install14N/A
Use update_sql() instead of db_query() in hook_update_N()Otherog_vocab.install58N/A
Use update_sql() instead of db_query() in hook_update_N()Otherog_vocab.install77N/A
Expandog_vocab.module515
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherog_vocab.module208N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module246N/A
Control statements should have one space between the control keyword and opening parenthesisOtherog_vocab.module265N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module265N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module371N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.module545N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module572N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherog_vocab.module585N/A
The control statement should be on a separate line from the control conditionalOtherog_vocab.module591N/A
put a space between the asterisk and the comment textOtherog_vocab.module607N/A
Format should be * Implementation of hook_foo().Otherog_vocab.module607N/A
Leafog_vocab.rules.inc000
Expandog_vocab.services.inc002
MessageGroupFilenameLineFunctionStatus
use a space between the closing parenthesis and the open bracketOtherog_vocab.services.inc51N/A
use a space between the closing parenthesis and the open bracketOtherog_vocab.services.inc58N/A
Expandog_vocab.test001
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherog_vocab.test2N/A
Leafog_vocab.token.inc000