Certify - 6.x-2.0-beta3

Test status
StatusResult
Last receivedWed, 02/08/2012 - 13:18:37
Last requestedWed, 02/08/2012 - 13:19:04
Last testedWed, 02/08/2012 - 13:19:39
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.0-beta3
ProjectCertify
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 10 minor(s), 4 critical(s), and 54 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
10 minor(s), 4 critical(s), and 54 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandcertify.admin.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercertify.admin.inc37N/A
Expandcertify.classes.inc311
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify.classes.inc6N/A
There should be no trailing spacesOthercertify.classes.inc116N/A
There should be no trailing spacesOthercertify.classes.inc195N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify.classes.inc221N/A
There should be no trailing spacesOthercertify.classes.inc241N/A
Expandcertify.install015
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify.install6N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercertify.install112N/A
Separate comments from comment syntax by a space.Othercertify.install177N/A
Function summaries should be one line only. (Drupal Docs)Othercertify.install180N/A
Function documentation should be less than 80 characters per line.Othercertify.install181N/A
else statements should begin on a new lineOthercertify.install190N/A
Expandcertify.module1125
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Othercertify.module182N/A
If you define a @param or @return, you should document it as well.Othercertify.module183N/A
If you define a @param or @return, you should document it as well.Othercertify.module184N/A
If you define a @param or @return, you should document it as well.Othercertify.module185N/A
else statements should begin on a new lineOthercertify.module215N/A
Use "elseif" in place of "else if"Othercertify.module215N/A
There should be no trailing spacesOthercertify.module230N/A
Function summaries should be one line only. (Drupal Docs)Othercertify.module245N/A
If you define a @param or @return, you should document it as well.Othercertify.module246N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module246N/A
If you define a @param or @return, you should document it as well.Othercertify.module247N/A
Function documentation should be less than 80 characters per line.Othercertify.module247N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module247N/A
If you define a @param or @return, you should document it as well.Othercertify.module248N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module248N/A
Separate comments from comment syntax by a space.Othercertify.module251N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercertify.module444N/A
Function documentation should be less than 80 characters per line.Othercertify.module471N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify.module652N/A
If you define a @param or @return, you should document it as well.Othercertify.module662N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module662N/A
If you define a @param or @return, you should document it as well.Othercertify.module687N/A
If you define a @param or @return, you should document it as well.Othercertify.module688N/A
If you define a @param or @return, you should document it as well.Othercertify.module689N/A
Function documentation should be less than 80 characters per line.Othercertify.module689N/A
If you define a @param or @return, you should document it as well.Othercertify.module690N/A
else statements should begin on a new lineOthercertify.module736N/A
Expandcertify_book/certify_book.classes.inc115
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othercertify_book.classes.inc7N/A
Separate comments from comment syntax by a space.Othercertify_book.classes.inc12N/A
Separate comments from comment syntax by a space.Othercertify_book.classes.inc48N/A
Doxygen uses @todo and @bug to markup things to be done.Othercertify_book.classes.inc59N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify_book.classes.inc86N/A
There should be no trailing spacesOthercertify_book.classes.inc125N/A
else statements should begin on a new lineOthercertify_book.classes.inc128N/A
Expandcertify_book/certify_book.install101
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_book.install6N/A
There should be no trailing spacesOthercertify_book.install8N/A
Expandcertify_book/certify_book.module203
MessageGroupFilenameLineFunctionStatus
Missing parenthesis after function nameOthercertify_book.module9N/A
Missing parenthesis after function nameOthercertify_book.module18N/A
Function summaries should be one line only. (Drupal Docs)Othercertify_book.module52N/A
Separate comments from comment syntax by a space.Othercertify_book.module57N/A
Separate comments from comment syntax by a space.Othercertify_book.module59N/A
Expandcertify_book/theme/certify_book_view.tpl.php004
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_book_view.tpl.php6N/A
else statements should begin on a new lineOthercertify_book_view.tpl.php15N/A
the final ?> should be omitted from all code filesOthercertify_book_view.tpl.php25N/A
else statements should begin on a new lineOthercertify_book_view.tpl.php26N/A
Expandcertify_quiz/certify_quiz.classes.inc003
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othercertify_quiz.classes.inc7N/A
Separate comments from comment syntax by a space.Othercertify_quiz.classes.inc35N/A
else statements should begin on a new lineOthercertify_quiz.classes.inc75N/A
Expandcertify_quiz/theme/certify_quiz_view.tpl.php003
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_quiz_view.tpl.php6N/A
the final ?> should be omitted from all code filesOthercertify_quiz_view.tpl.php13N/A
else statements should begin on a new lineOthercertify_quiz_view.tpl.php13N/A
Expandtheme/certificate-single.tpl.php001
MessageGroupFilenameLineFunctionStatus
else statements should begin on a new lineOthercertificate-single.tpl.php27N/A
Expandtheme/certify-view.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthercertify-view.tpl.php16N/A
Expandtheme/certify.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthercertify.tpl.php11N/A

All

Test nameMinorCriticalNormal
Expandcertify.admin.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercertify.admin.inc37N/A
Expandcertify.classes.inc311
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify.classes.inc6N/A
There should be no trailing spacesOthercertify.classes.inc116N/A
There should be no trailing spacesOthercertify.classes.inc195N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify.classes.inc221N/A
There should be no trailing spacesOthercertify.classes.inc241N/A
Expandcertify.install015
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify.install6N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercertify.install112N/A
Separate comments from comment syntax by a space.Othercertify.install177N/A
Function summaries should be one line only. (Drupal Docs)Othercertify.install180N/A
Function documentation should be less than 80 characters per line.Othercertify.install181N/A
else statements should begin on a new lineOthercertify.install190N/A
Expandcertify.module1125
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Othercertify.module182N/A
If you define a @param or @return, you should document it as well.Othercertify.module183N/A
If you define a @param or @return, you should document it as well.Othercertify.module184N/A
If you define a @param or @return, you should document it as well.Othercertify.module185N/A
else statements should begin on a new lineOthercertify.module215N/A
Use "elseif" in place of "else if"Othercertify.module215N/A
There should be no trailing spacesOthercertify.module230N/A
Function summaries should be one line only. (Drupal Docs)Othercertify.module245N/A
If you define a @param or @return, you should document it as well.Othercertify.module246N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module246N/A
If you define a @param or @return, you should document it as well.Othercertify.module247N/A
Function documentation should be less than 80 characters per line.Othercertify.module247N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module247N/A
If you define a @param or @return, you should document it as well.Othercertify.module248N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module248N/A
Separate comments from comment syntax by a space.Othercertify.module251N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercertify.module444N/A
Function documentation should be less than 80 characters per line.Othercertify.module471N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify.module652N/A
If you define a @param or @return, you should document it as well.Othercertify.module662N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othercertify.module662N/A
If you define a @param or @return, you should document it as well.Othercertify.module687N/A
If you define a @param or @return, you should document it as well.Othercertify.module688N/A
If you define a @param or @return, you should document it as well.Othercertify.module689N/A
Function documentation should be less than 80 characters per line.Othercertify.module689N/A
If you define a @param or @return, you should document it as well.Othercertify.module690N/A
else statements should begin on a new lineOthercertify.module736N/A
Expandcertify_book/certify_book.classes.inc115
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othercertify_book.classes.inc7N/A
Separate comments from comment syntax by a space.Othercertify_book.classes.inc12N/A
Separate comments from comment syntax by a space.Othercertify_book.classes.inc48N/A
Doxygen uses @todo and @bug to markup things to be done.Othercertify_book.classes.inc59N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othercertify_book.classes.inc86N/A
There should be no trailing spacesOthercertify_book.classes.inc125N/A
else statements should begin on a new lineOthercertify_book.classes.inc128N/A
Expandcertify_book/certify_book.install101
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_book.install6N/A
There should be no trailing spacesOthercertify_book.install8N/A
Expandcertify_book/certify_book.module203
MessageGroupFilenameLineFunctionStatus
Missing parenthesis after function nameOthercertify_book.module9N/A
Missing parenthesis after function nameOthercertify_book.module18N/A
Function summaries should be one line only. (Drupal Docs)Othercertify_book.module52N/A
Separate comments from comment syntax by a space.Othercertify_book.module57N/A
Separate comments from comment syntax by a space.Othercertify_book.module59N/A
Expandcertify_book/theme/certify_book_view.tpl.php004
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_book_view.tpl.php6N/A
else statements should begin on a new lineOthercertify_book_view.tpl.php15N/A
the final ?> should be omitted from all code filesOthercertify_book_view.tpl.php25N/A
else statements should begin on a new lineOthercertify_book_view.tpl.php26N/A
Expandcertify_quiz/certify_quiz.classes.inc003
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othercertify_quiz.classes.inc7N/A
Separate comments from comment syntax by a space.Othercertify_quiz.classes.inc35N/A
else statements should begin on a new lineOthercertify_quiz.classes.inc75N/A
Expandcertify_quiz/certify_quiz.module200
MessageGroupFilenameLineFunctionStatus
Missing parenthesis after function nameOthercertify_quiz.module9N/A
Missing parenthesis after function nameOthercertify_quiz.module18N/A
Expandcertify_quiz/theme/certify_quiz_view.tpl.php003
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Othercertify_quiz_view.tpl.php6N/A
the final ?> should be omitted from all code filesOthercertify_quiz_view.tpl.php13N/A
else statements should begin on a new lineOthercertify_quiz_view.tpl.php13N/A
Expandtheme/certificate-single.tpl.php001
MessageGroupFilenameLineFunctionStatus
else statements should begin on a new lineOthercertificate-single.tpl.php27N/A
Expandtheme/certify-view.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthercertify-view.tpl.php16N/A
Expandtheme/certify.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthercertify.tpl.php11N/A