Mapstraction - 6.x-2.x

Test status
StatusResult
Last receivedSun, 01/15/2012 - 12:12:36
Last requestedSun, 01/15/2012 - 12:13:02
Last testedSun, 01/15/2012 - 12:13:43
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.x
ProjectMapstraction
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 19 minor(s), 1 critical(s), and 34 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
19 minor(s), 1 critical(s), and 34 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandmapstraction.apis.inc401
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthermapstraction.apis.inc14N/A
There should be no trailing spacesOthermapstraction.apis.inc37N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.apis.inc40N/A
There should be no trailing spacesOthermapstraction.apis.inc49N/A
There should be no trailing spacesOthermapstraction.apis.inc68N/A
Expandmapstraction.install107
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermapstraction.install-1N/A
Format should be * Implementation of hook_foo().Othermapstraction.install4N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install6N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.install7N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install7N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.install8N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install8N/A
the final ?> should be omitted from all code filesOthermapstraction.install12N/A
Expandmapstraction.module9015
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthermapstraction.module18N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module55N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module59N/A
There should be no trailing spacesOthermapstraction.module63N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.module64N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module64N/A
Function summaries should be one line only. (Drupal Docs)Othermapstraction.module98N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module108N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module114N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module144N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module155N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module187N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module188N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module189N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module190N/A
There should be no trailing spacesOthermapstraction.module195N/A
There should be no trailing spacesOthermapstraction.module201N/A
There should be no trailing spacesOthermapstraction.module219N/A
There should be no trailing spacesOthermapstraction.module224N/A
There should be no trailing spacesOthermapstraction.module232N/A
There should be no trailing spacesOthermapstraction.module246N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module248N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module251N/A
There should be no trailing spacesOthermapstraction.module254N/A
Expandmapstraction_style_map.inc5111
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc53N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Othermapstraction_style_map.inc54N/A
There should be no trailing spacesOthermapstraction_style_map.inc130N/A
There should be no trailing spacesOthermapstraction_style_map.inc141N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc177N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc189N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othermapstraction_style_map.inc231N/A
There should be no trailing spacesOthermapstraction_style_map.inc288N/A
There should be no trailing spacesOthermapstraction_style_map.inc299N/A
There should be no trailing spacesOthermapstraction_style_map.inc302N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction_style_map.inc326N/A
Separate comments from comment syntax by a space.Othermapstraction_style_map.inc327N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc356N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction_style_map.inc357N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc357N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc381N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc382N/A

All

Test nameMinorCriticalNormal
Leafmapstraction-map.tpl.php000
Expandmapstraction.apis.inc401
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthermapstraction.apis.inc14N/A
There should be no trailing spacesOthermapstraction.apis.inc37N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.apis.inc40N/A
There should be no trailing spacesOthermapstraction.apis.inc49N/A
There should be no trailing spacesOthermapstraction.apis.inc68N/A
Expandmapstraction.install107
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermapstraction.install-1N/A
Format should be * Implementation of hook_foo().Othermapstraction.install4N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install6N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.install7N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install7N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.install8N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.install8N/A
the final ?> should be omitted from all code filesOthermapstraction.install12N/A
Expandmapstraction.module9015
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthermapstraction.module18N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module55N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module59N/A
There should be no trailing spacesOthermapstraction.module63N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction.module64N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module64N/A
Function summaries should be one line only. (Drupal Docs)Othermapstraction.module98N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module108N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module114N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module144N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction.module155N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module187N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module188N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module189N/A
If you define a @param or @return, you should document it as well.Othermapstraction.module190N/A
There should be no trailing spacesOthermapstraction.module195N/A
There should be no trailing spacesOthermapstraction.module201N/A
There should be no trailing spacesOthermapstraction.module219N/A
There should be no trailing spacesOthermapstraction.module224N/A
There should be no trailing spacesOthermapstraction.module232N/A
There should be no trailing spacesOthermapstraction.module246N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module248N/A
use a space between the closing parenthesis and the open bracketOthermapstraction.module251N/A
There should be no trailing spacesOthermapstraction.module254N/A
Expandmapstraction_style_map.inc5111
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc53N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Othermapstraction_style_map.inc54N/A
There should be no trailing spacesOthermapstraction_style_map.inc130N/A
There should be no trailing spacesOthermapstraction_style_map.inc141N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc177N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermapstraction_style_map.inc189N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othermapstraction_style_map.inc231N/A
There should be no trailing spacesOthermapstraction_style_map.inc288N/A
There should be no trailing spacesOthermapstraction_style_map.inc299N/A
There should be no trailing spacesOthermapstraction_style_map.inc302N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction_style_map.inc326N/A
Separate comments from comment syntax by a space.Othermapstraction_style_map.inc327N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc356N/A
Control statements should have one space between the control keyword and opening parenthesisOthermapstraction_style_map.inc357N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc357N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc381N/A
use a space between the closing parenthesis and the open bracketOthermapstraction_style_map.inc382N/A