mojeID integration - 7.x-1.x

Test status
StatusResult
Last receivedWed, 01/11/2012 - 23:15:36
Last requestedWed, 01/11/2012 - 23:16:03
Last testedWed, 01/11/2012 - 23:16:27
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectmojeID integration
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 8 minor(s), 1 critical(s), and 70 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
8 minor(s), 1 critical(s), and 70 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandmojeid.admin.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.admin.inc-1N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.admin.inc11N/A
Expandmojeid.inc6159
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.inc-1N/A
Separate comments from comment syntax by a space.Othermojeid.inc4N/A
Separate comments from comment syntax by a space.Othermojeid.inc6N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc18N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc19N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc20N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc21N/A
Separate comments from comment syntax by a space.Othermojeid.inc29N/A
Separate comments from comment syntax by a space.Othermojeid.inc31N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othermojeid.inc276N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othermojeid.inc276N/A
Separate comments from comment syntax by a space.Othermojeid.inc307N/A
Separate comments from comment syntax by a space.Othermojeid.inc309N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthermojeid.inc313N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc319N/A
Function summaries should be one line only. (Drupal Docs)Othermojeid.inc327N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc333N/A
Function documentation should be less than 80 characters per line.Othermojeid.inc338N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc368N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc370N/A
Separate comments from comment syntax by a space.Othermojeid.inc378N/A
Separate comments from comment syntax by a space.Othermojeid.inc380N/A
Use an indent of 2 spaces, with no tabsOthermojeid.inc461N/A
Separate comments from comment syntax by a space.Othermojeid.inc466N/A
Separate comments from comment syntax by a space.Othermojeid.inc478N/A
Separate comments from comment syntax by a space.Othermojeid.inc487N/A
Separate comments from comment syntax by a space.Othermojeid.inc496N/A
Separate comments from comment syntax by a space.Othermojeid.inc513N/A
Separate comments from comment syntax by a space.Othermojeid.inc522N/A
Separate comments from comment syntax by a space.Othermojeid.inc531N/A
Separate comments from comment syntax by a space.Othermojeid.inc543N/A
Separate comments from comment syntax by a space.Othermojeid.inc552N/A
Separate comments from comment syntax by a space.Othermojeid.inc561N/A
Separate comments from comment syntax by a space.Othermojeid.inc570N/A
Separate comments from comment syntax by a space.Othermojeid.inc579N/A
Separate comments from comment syntax by a space.Othermojeid.inc588N/A
Separate comments from comment syntax by a space.Othermojeid.inc597N/A
Separate comments from comment syntax by a space.Othermojeid.inc609N/A
Separate comments from comment syntax by a space.Othermojeid.inc618N/A
Separate comments from comment syntax by a space.Othermojeid.inc627N/A
Separate comments from comment syntax by a space.Othermojeid.inc636N/A
Separate comments from comment syntax by a space.Othermojeid.inc645N/A
Separate comments from comment syntax by a space.Othermojeid.inc654N/A
Separate comments from comment syntax by a space.Othermojeid.inc663N/A
Separate comments from comment syntax by a space.Othermojeid.inc675N/A
Separate comments from comment syntax by a space.Othermojeid.inc684N/A
Separate comments from comment syntax by a space.Othermojeid.inc696N/A
Separate comments from comment syntax by a space.Othermojeid.inc705N/A
Separate comments from comment syntax by a space.Othermojeid.inc714N/A
Separate comments from comment syntax by a space.Othermojeid.inc723N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc726N/A
Separate comments from comment syntax by a space.Othermojeid.inc732N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc735N/A
Separate comments from comment syntax by a space.Othermojeid.inc740N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc743N/A
Separate comments from comment syntax by a space.Othermojeid.inc752N/A
Separate comments from comment syntax by a space.Othermojeid.inc761N/A
Separate comments from comment syntax by a space.Othermojeid.inc773N/A
Separate comments from comment syntax by a space.Othermojeid.inc782N/A
Separate comments from comment syntax by a space.Othermojeid.inc791N/A
Separate comments from comment syntax by a space.Othermojeid.inc800N/A
Separate comments from comment syntax by a space.Othermojeid.inc809N/A
Separate comments from comment syntax by a space.Othermojeid.inc821N/A
Separate comments from comment syntax by a space.Othermojeid.inc830N/A
Separate comments from comment syntax by a space.Othermojeid.inc839N/A
Separate comments from comment syntax by a space.Othermojeid.inc851N/A
Expandmojeid.install101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.install-1N/A
There should be no trailing spacesOthermojeid.install23N/A
Expandmojeid.module108
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othermojeid.module17N/A
Separate comments from comment syntax by a space.Othermojeid.module19N/A
Separate comments from comment syntax by a space.Othermojeid.module23N/A
Separate comments from comment syntax by a space.Othermojeid.module25N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.module61N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module77N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module82N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module85N/A
put a space between the asterisk and the comment textOthermojeid.module167N/A

All

Test nameMinorCriticalNormal
Expandmojeid.admin.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.admin.inc-1N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.admin.inc11N/A
Expandmojeid.inc6159
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.inc-1N/A
Separate comments from comment syntax by a space.Othermojeid.inc4N/A
Separate comments from comment syntax by a space.Othermojeid.inc6N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc18N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc19N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc20N/A
use lowercase html tags to comply with XHTMLOthermojeid.inc21N/A
Separate comments from comment syntax by a space.Othermojeid.inc29N/A
Separate comments from comment syntax by a space.Othermojeid.inc31N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othermojeid.inc276N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othermojeid.inc276N/A
Separate comments from comment syntax by a space.Othermojeid.inc307N/A
Separate comments from comment syntax by a space.Othermojeid.inc309N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthermojeid.inc313N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc319N/A
Function summaries should be one line only. (Drupal Docs)Othermojeid.inc327N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc333N/A
Function documentation should be less than 80 characters per line.Othermojeid.inc338N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc368N/A
If you define a @param or @return, you should document it as well.Othermojeid.inc370N/A
Separate comments from comment syntax by a space.Othermojeid.inc378N/A
Separate comments from comment syntax by a space.Othermojeid.inc380N/A
Use an indent of 2 spaces, with no tabsOthermojeid.inc461N/A
Separate comments from comment syntax by a space.Othermojeid.inc466N/A
Separate comments from comment syntax by a space.Othermojeid.inc478N/A
Separate comments from comment syntax by a space.Othermojeid.inc487N/A
Separate comments from comment syntax by a space.Othermojeid.inc496N/A
Separate comments from comment syntax by a space.Othermojeid.inc513N/A
Separate comments from comment syntax by a space.Othermojeid.inc522N/A
Separate comments from comment syntax by a space.Othermojeid.inc531N/A
Separate comments from comment syntax by a space.Othermojeid.inc543N/A
Separate comments from comment syntax by a space.Othermojeid.inc552N/A
Separate comments from comment syntax by a space.Othermojeid.inc561N/A
Separate comments from comment syntax by a space.Othermojeid.inc570N/A
Separate comments from comment syntax by a space.Othermojeid.inc579N/A
Separate comments from comment syntax by a space.Othermojeid.inc588N/A
Separate comments from comment syntax by a space.Othermojeid.inc597N/A
Separate comments from comment syntax by a space.Othermojeid.inc609N/A
Separate comments from comment syntax by a space.Othermojeid.inc618N/A
Separate comments from comment syntax by a space.Othermojeid.inc627N/A
Separate comments from comment syntax by a space.Othermojeid.inc636N/A
Separate comments from comment syntax by a space.Othermojeid.inc645N/A
Separate comments from comment syntax by a space.Othermojeid.inc654N/A
Separate comments from comment syntax by a space.Othermojeid.inc663N/A
Separate comments from comment syntax by a space.Othermojeid.inc675N/A
Separate comments from comment syntax by a space.Othermojeid.inc684N/A
Separate comments from comment syntax by a space.Othermojeid.inc696N/A
Separate comments from comment syntax by a space.Othermojeid.inc705N/A
Separate comments from comment syntax by a space.Othermojeid.inc714N/A
Separate comments from comment syntax by a space.Othermojeid.inc723N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc726N/A
Separate comments from comment syntax by a space.Othermojeid.inc732N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc735N/A
Separate comments from comment syntax by a space.Othermojeid.inc740N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.inc743N/A
Separate comments from comment syntax by a space.Othermojeid.inc752N/A
Separate comments from comment syntax by a space.Othermojeid.inc761N/A
Separate comments from comment syntax by a space.Othermojeid.inc773N/A
Separate comments from comment syntax by a space.Othermojeid.inc782N/A
Separate comments from comment syntax by a space.Othermojeid.inc791N/A
Separate comments from comment syntax by a space.Othermojeid.inc800N/A
Separate comments from comment syntax by a space.Othermojeid.inc809N/A
Separate comments from comment syntax by a space.Othermojeid.inc821N/A
Separate comments from comment syntax by a space.Othermojeid.inc830N/A
Separate comments from comment syntax by a space.Othermojeid.inc839N/A
Separate comments from comment syntax by a space.Othermojeid.inc851N/A
Expandmojeid.install101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermojeid.install-1N/A
There should be no trailing spacesOthermojeid.install23N/A
Expandmojeid.module108
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othermojeid.module17N/A
Separate comments from comment syntax by a space.Othermojeid.module19N/A
Separate comments from comment syntax by a space.Othermojeid.module23N/A
Separate comments from comment syntax by a space.Othermojeid.module25N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othermojeid.module61N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module77N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module82N/A
Use the matching Drupal theme functions, not raw HTML.Othermojeid.module85N/A
put a space between the asterisk and the comment textOthermojeid.module167N/A