LoginToboggan - 7.x-1.3

Test status
StatusResult
Last receivedWed, 01/11/2012 - 13:03:37
Last requestedWed, 01/11/2012 - 13:04:04
Last testedWed, 01/11/2012 - 13:04:36
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.3
ProjectLoginToboggan
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 8 minor(s), 2 critical(s), and 52 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
8 minor(s), 2 critical(s), and 52 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandcontrib/logintoboggan_content_access_integration/logintoboggan_content_access_integration.install203
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_content_access_integration.install-1N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.install11N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.install20N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan_content_access_integration.install34N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan_content_access_integration.install38N/A
Expandcontrib/logintoboggan_content_access_integration/logintoboggan_content_access_integration.module002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_content_access_integration.module-1N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.module6N/A
Expandcontrib/logintoboggan_rules/logintoboggan_rules.module001
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Otherlogintoboggan_rules.module15N/A
Expandcontrib/logintoboggan_rules/logintoboggan_rules.rules.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_rules.rules.inc-1N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan_rules.rules.inc4N/A
Expandcontrib/logintoboggan_variable/logintoboggan_variable.module001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_variable.module-1N/A
Expandlogintoboggan.admin.inc007
MessageGroupFilenameLineFunctionStatus
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherlogintoboggan.admin.inc47N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc47N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc56N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc67N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.admin.inc104N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.admin.inc105N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.admin.inc188N/A
Expandlogintoboggan.install302
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherlogintoboggan.install4N/A
indent secondary line of comment one space Otherlogintoboggan.install5N/A
indent secondary line of comment one space Otherlogintoboggan.install6N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.install17N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan.install60N/A
Expandlogintoboggan.module3132
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module7N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.module12N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.module17N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module80N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module81N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module90N/A
missing space after commaOtherlogintoboggan.module242N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module247N/A
missing space after commaOtherlogintoboggan.module348N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.module395N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module396N/A
Control statements should have one space between the control keyword and opening parenthesisOtherlogintoboggan.module507N/A
else statements should begin on a new lineOtherlogintoboggan.module516N/A
Control statements should have one space between the control keyword and opening parenthesisOtherlogintoboggan.module533N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module563N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module570N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module636N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module637N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module639N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module640N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module740N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherlogintoboggan.module754N/A
Format should be * Implementation of hook_foo().Otherlogintoboggan.module761N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherlogintoboggan.module855N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module871N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherlogintoboggan.module940N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan.module961N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherlogintoboggan.module965N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1020N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1046N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherlogintoboggan.module1060N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1161N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1179N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1195N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1204N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1231N/A
Expandlogintoboggan.validation.inc012
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.validation.inc9N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherlogintoboggan.validation.inc72N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherlogintoboggan.validation.inc78N/A

All

Test nameMinorCriticalNormal
Expandcontrib/logintoboggan_content_access_integration/logintoboggan_content_access_integration.install203
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_content_access_integration.install-1N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.install11N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.install20N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan_content_access_integration.install34N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan_content_access_integration.install38N/A
Expandcontrib/logintoboggan_content_access_integration/logintoboggan_content_access_integration.module002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_content_access_integration.module-1N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan_content_access_integration.module6N/A
Expandcontrib/logintoboggan_rules/logintoboggan_rules.module001
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Otherlogintoboggan_rules.module15N/A
Expandcontrib/logintoboggan_rules/logintoboggan_rules.rules.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_rules.rules.inc-1N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan_rules.rules.inc4N/A
Expandcontrib/logintoboggan_variable/logintoboggan_variable.module001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherlogintoboggan_variable.module-1N/A
Expandlogintoboggan.admin.inc007
MessageGroupFilenameLineFunctionStatus
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherlogintoboggan.admin.inc47N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc47N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc56N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.admin.inc67N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.admin.inc104N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.admin.inc105N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.admin.inc188N/A
Expandlogintoboggan.install302
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherlogintoboggan.install4N/A
indent secondary line of comment one space Otherlogintoboggan.install5N/A
indent secondary line of comment one space Otherlogintoboggan.install6N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.install17N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan.install60N/A
Expandlogintoboggan.module3132
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module7N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.module12N/A
Remove the empty commented line in your function documentation.Otherlogintoboggan.module17N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module80N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module81N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module90N/A
missing space after commaOtherlogintoboggan.module242N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module247N/A
missing space after commaOtherlogintoboggan.module348N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherlogintoboggan.module395N/A
Use the matching Drupal theme functions, not raw HTML.Otherlogintoboggan.module396N/A
Control statements should have one space between the control keyword and opening parenthesisOtherlogintoboggan.module507N/A
else statements should begin on a new lineOtherlogintoboggan.module516N/A
Control statements should have one space between the control keyword and opening parenthesisOtherlogintoboggan.module533N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module563N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module570N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module636N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module637N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module639N/A
Function documentation should be less than 80 characters per line.Otherlogintoboggan.module640N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module740N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherlogintoboggan.module754N/A
Format should be * Implementation of hook_foo().Otherlogintoboggan.module761N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherlogintoboggan.module855N/A
Separate comments from comment syntax by a space.Otherlogintoboggan.module871N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherlogintoboggan.module940N/A
Use an indent of 2 spaces, with no tabsOtherlogintoboggan.module961N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherlogintoboggan.module965N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1020N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1046N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherlogintoboggan.module1060N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1161N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1179N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1195N/A
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.module1204N/A
use a space between the closing parenthesis and the open bracketOtherlogintoboggan.module1231N/A
Leaflogintoboggan.tokens.inc000
Expandlogintoboggan.validation.inc012
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Otherlogintoboggan.validation.inc9N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherlogintoboggan.validation.inc72N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherlogintoboggan.validation.inc78N/A