Contact Forms - 7.x-1.x

Test status
StatusResult
Last receivedSat, 01/07/2012 - 19:00:54
Last requestedSat, 01/07/2012 - 19:01:32
Last testedSat, 01/07/2012 - 19:01:39
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectContact Forms
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 10 minor(s), 1 critical(s), and 29 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
10 minor(s), 1 critical(s), and 29 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandcontact_forms.install018
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othercontact_forms.install-1N/A
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Othercontact_forms.install2N/A
Separate comments from comment syntax by a space.Othercontact_forms.install8N/A
Functions should be called with no spaces between the function name and opening parenthesesOthercontact_forms.install15N/A
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N()Othercontact_forms.install16N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercontact_forms.install16N/A
The $text argument to l() should be enclosed within st() so that it is translatable from within the install.Othercontact_forms.install17N/A
Separate comments from comment syntax by a space.Othercontact_forms.install31N/A
Functions should be called with no spaces between the function name and opening parenthesesOthercontact_forms.install41N/A
Expandcontact_forms.module10021
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Othercontact_forms.module2N/A
Function documentation should be less than 80 characters per line.Othercontact_forms.module6N/A
Administrative menu items should have a description.Othercontact_forms.module14N/A
put a space between the asterisk and the comment textOthercontact_forms.module19N/A
Missing parenthesis after function nameOthercontact_forms.module26N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module47N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module53N/A
"Module" should rarely be capitalized as part of a module's proper name.Othercontact_forms.module57N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module57N/A
Missing parenthesis after function nameOthercontact_forms.module64N/A
use a space between the closing parenthesis and the open bracketOthercontact_forms.module66N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module68N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercontact_forms.module77N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercontact_forms.module87N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module96N/A
Missing periodOthercontact_forms.module103N/A
missing space after commaOthercontact_forms.module119N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module149N/A
missing space after commaOthercontact_forms.module151N/A
Control statements should have one space between the control keyword and opening parenthesisOthercontact_forms.module170N/A
use a space between the closing parenthesis and the open bracketOthercontact_forms.module170N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module187N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module196N/A
Missing parenthesis after function nameOthercontact_forms.module209N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module211N/A
Function summaries should be one line only. (Drupal Docs)Othercontact_forms.module227N/A
l() already contains a check_plain() call by defaultOthercontact_forms.module256N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module259N/A
Missing parenthesis after function nameOthercontact_forms.module279N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module285N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module292N/A

All

Test nameMinorCriticalNormal
Expandcontact_forms.install018
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othercontact_forms.install-1N/A
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Othercontact_forms.install2N/A
Separate comments from comment syntax by a space.Othercontact_forms.install8N/A
Functions should be called with no spaces between the function name and opening parenthesesOthercontact_forms.install15N/A
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N()Othercontact_forms.install16N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercontact_forms.install16N/A
The $text argument to l() should be enclosed within st() so that it is translatable from within the install.Othercontact_forms.install17N/A
Separate comments from comment syntax by a space.Othercontact_forms.install31N/A
Functions should be called with no spaces between the function name and opening parenthesesOthercontact_forms.install41N/A
Expandcontact_forms.module10021
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Othercontact_forms.module2N/A
Function documentation should be less than 80 characters per line.Othercontact_forms.module6N/A
Administrative menu items should have a description.Othercontact_forms.module14N/A
put a space between the asterisk and the comment textOthercontact_forms.module19N/A
Missing parenthesis after function nameOthercontact_forms.module26N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module47N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module53N/A
"Module" should rarely be capitalized as part of a module's proper name.Othercontact_forms.module57N/A
Use the matching Drupal theme functions, not raw HTML.Othercontact_forms.module57N/A
Missing parenthesis after function nameOthercontact_forms.module64N/A
use a space between the closing parenthesis and the open bracketOthercontact_forms.module66N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module68N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercontact_forms.module77N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercontact_forms.module87N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module96N/A
Missing periodOthercontact_forms.module103N/A
missing space after commaOthercontact_forms.module119N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module149N/A
missing space after commaOthercontact_forms.module151N/A
Control statements should have one space between the control keyword and opening parenthesisOthercontact_forms.module170N/A
use a space between the closing parenthesis and the open bracketOthercontact_forms.module170N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module187N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module196N/A
Missing parenthesis after function nameOthercontact_forms.module209N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module211N/A
Function summaries should be one line only. (Drupal Docs)Othercontact_forms.module227N/A
l() already contains a check_plain() call by defaultOthercontact_forms.module256N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othercontact_forms.module259N/A
Missing parenthesis after function nameOthercontact_forms.module279N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module285N/A
Use an indent of 2 spaces, with no tabsOthercontact_forms.module292N/A