Text or Nodereference - 6.x-1.0

Test status
StatusResult
Last receivedMon, 01/02/2012 - 18:23:38
Last requestedMon, 01/02/2012 - 18:24:03
Last testedMon, 01/02/2012 - 18:24:25
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-1.0
ProjectText or Nodereference
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 3 minor(s), 1 critical(s), and 5 normal(s); [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh.
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
    Ensure that you can install SimpleTest locally and invoke tests using the command line script.
  9. Detect a failing test
  10. Complete test suite with all tests passing
Review log
[11:24:01] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_209103.pifr_simpletest.1325528641.log)
[11:24:01] Environment variables and review information initialized.
[11:24:01] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/text_noderef.git]
[11:24:01] Project directory is [text_noderef]
[11:24:01] Review started.
[11:24:01] Invoking operation [setup]...
[11:24:01] Command [rm -rf sites/default/files/checkout 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot]
  Completion status: [0]
  Output: no output.
[11:24:01] Command [rm -rf sites/default/files/review 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot]
  Completion status: [0]
  Output: no output.
[11:24:01] Database backend [mysql] loaded.
[11:24:02] Invoking operation [fetch]...
[11:24:02] Invoking operation [checkout]...
[11:24:02] Version control system backend [git] loaded.
[11:24:03] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded
  Duration: 1 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files]
  Completion status: [0]
  Output: [Cloning into checkout...].
[11:24:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files]
  Completion status: [0]
  Output: [Switched to a new branch '6.x'
Branch 6.x set up to track remote branch 6.x from origin.].
[11:24:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files]
  Completion status: [0]
  Output: [# On branch 6.x
nothing to commit (working directory clean)].
[11:24:03] Main branch [6.x] checkout [complete].
[11:24:12] Command [git clone 'git://git.drupal.org/project/cck.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --reference /var/cache/git/reference 2>&1] succeeded
  Duration: 9 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Cloning into /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck...].
[11:24:12] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/.git' checkout '6.x-3.0-alpha3' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Note: checking out '6.x-3.0-alpha3'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at aa311f8... Update CHANGELOG.txt.].
[11:24:12] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/.git' status 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [# Not currently on any branch.
nothing to commit (working directory clean)].
[11:24:12] Dependency branch [6.x-3.0-alpha3] checkout [complete].
[11:24:18] Command [git clone 'git://git.drupal.org/project/text_noderef.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef' --reference /var/cache/git/reference 2>&1] succeeded
  Duration: 6 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Cloning into /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef...].
[11:24:18] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef/.git' checkout '6.x-1.0' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Note: checking out '6.x-1.0'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 5ba1c39... Initial commit of text_noderef.module. Allows textfield to be rendered like a node reference, with some autocompletion magic on edits.].
[11:24:18] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/text_noderef/.git' status 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [# Not currently on any branch.
nothing to commit (working directory clean)].
[11:24:18] Dependency branch [6.x-1.0] checkout [complete].
[11:24:19] Command [git clone 'git://git.drupal.org/project/simpletest.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --reference /var/cache/git/reference 2>&1] succeeded
  Duration: 1 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Cloning into /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest...].
[11:24:19] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' checkout '6.x-2.x' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [Switched to a new branch '6.x-2.x'
Branch 6.x-2.x set up to track remote branch 6.x-2.x from origin.].
[11:24:19] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' status 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
  Completion status: [0]
  Output: [# On branch 6.x-2.x
nothing to commit (working directory clean)].
[11:24:19] Dependency branch [6.x-2.x] checkout [complete].
[11:24:19] Invoking operation [check]...
[11:24:19] Ignoring operation [check].
[11:24:19] Invoking operation [apply]...
[11:24:19] Ignoring operation [apply].
[11:24:19] Invoking operation [syntax]...
[11:24:19] Command [php -l -f './sites/default/modules/text_noderef/text_noderef.module' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [No syntax errors detected in ./sites/default/modules/text_noderef/text_noderef.module].
[11:24:19] Command [php -l -f './sites/default/modules/text_noderef/text_noderef.install' 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [No syntax errors detected in ./sites/default/modules/text_noderef/text_noderef.install].
[11:24:19] Checked [2 of 2] relevant file(s) for syntax.
[11:24:19] Invoking operation [install]...
[11:24:22] Invoking operation [review]...
[11:24:22] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=sites/default/modules/simpletest/D6-core-simpletest.patch
[11:24:22] Command [git apply --check -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: no output.
[11:24:22] Command [git apply -v -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [Checking patch install.php...
Checking patch includes/bootstrap.inc...
Checking patch includes/common.inc...
Applied patch install.php cleanly.
Applied patch includes/bootstrap.inc cleanly.
Applied patch includes/common.inc cleanly.].
[11:24:22] Completed Drupal 6 SimpleTest installation.
[11:24:23] Cleaning run-tests.sh environment:  /usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot659-mysql/checkout' --file 
[11:24:23] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot659-mysql/checkout' --file  --clean 2>&1] succeeded
  Duration: 0 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [Environment cleaned.
 - No leftover tables to remove.
 - No temporary directories to remove.].
[11:24:23] Initiating run-tests.sh with command:  /usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot659-mysql/checkout' --file 
[11:24:23] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot659-mysql/checkout' --file  2>&1] failed
  Duration 0 seconds
  Directory [/var/lib/drupaltestbot/sites/default/files/checkout]
  Status [255]
 Output: [PHP Fatal error:  Class 'ContentCrudTestCase' not found in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/tests/fieldgroup.test on line 3].
[11:24:23] Encountered error on [review], details:
array (
  '@reason' => 'failed during invocation of run-tests.sh',
)
[11:24:23] Review complete. test_id=209103 result code=8 details=Array
(
    [@reason] => failed during invocation of run-tests.sh
)

[11:24:23] Static variables reset.

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
3 minor(s), 1 critical(s), and 5 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandtext_noderef.module315
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othertext_noderef.module14N/A
put a space between the asterisk and the comment textOthertext_noderef.module93N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module145N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module150N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module155N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module165N/A
put a space between the asterisk and the comment textOthertext_noderef.module176N/A
put a space between the asterisk and the comment textOthertext_noderef.module247N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othertext_noderef.module288N/A

All

Test nameMinorCriticalNormal
Leaftext_noderef.install000
Expandtext_noderef.module315
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othertext_noderef.module14N/A
put a space between the asterisk and the comment textOthertext_noderef.module93N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module145N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module150N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module155N/A
Use the matching Drupal theme functions, not raw HTML.Othertext_noderef.module165N/A
put a space between the asterisk and the comment textOthertext_noderef.module176N/A
put a space between the asterisk and the comment textOthertext_noderef.module247N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othertext_noderef.module288N/A