Gravatar integration - 6.x-1.x

Test status
StatusResult
Last receivedSat, 01/07/2012 - 19:58:36
Last requestedSat, 01/07/2012 - 19:59:03
Last testedSat, 01/07/2012 - 19:59:22
Test count6
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-1.x
ProjectGravatar integration
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 1 minor(s), 4 critical(s), and 26 normal(s); [[SimpleTest]]: [MySQL] 6 pass(es), 0 fail(s), and 1 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
6 pass(es), 0 fail(s), and 1 exception(s)

Non-pass

Test namePassFailException
ExpandGravatarUnitTest601
MessageGroupFilenameLineFunctionStatus
file_exists() expects parameter 1 to be string, object givenWarninggravatar.module165_gravatar_get_account_user_picture()

All

Test namePassFailException
ExpandGravatarUnitTest601
MessageGroupFilenameLineFunctionStatus
file_exists() expects parameter 1 to be string, object givenWarninggravatar.module165_gravatar_get_account_user_picture()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
1 minor(s), 4 critical(s), and 26 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandgravatar.admin.inc003
MessageGroupFilenameLineFunctionStatus
Use the matching Drupal theme functions, not raw HTML.Othergravatar.admin.inc36N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othergravatar.admin.inc66N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.admin.inc82N/A
Expandgravatar.author-pane.inc103
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc12N/A
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc13N/A
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc14N/A
There should be no trailing spacesOthergravatar.author-pane.inc15N/A
Expandgravatar.install015
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othergravatar.install43N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install57N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install63N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install71N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install78N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install87N/A
Expandgravatar.module0314
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.module89N/A
Separate comments from comment syntax by a space.Othergravatar.module91N/A
Separate comments from comment syntax by a space.Othergravatar.module92N/A
Separate comments from comment syntax by a space.Othergravatar.module93N/A
Separate comments from comment syntax by a space.Othergravatar.module94N/A
Separate comments from comment syntax by a space.Othergravatar.module95N/A
Function summaries should be one line only. (Drupal Docs)Othergravatar.module120N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module234N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module255N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module264N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othergravatar.module269N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othergravatar.module298N/A
Separate comments from comment syntax by a space.Othergravatar.module313N/A
Separate comments from comment syntax by a space.Othergravatar.module321N/A
Separate comments from comment syntax by a space.Othergravatar.module387N/A
Potential problem: trigger_error() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergravatar.module397N/A
Potential problem: trigger_error() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergravatar.module455N/A
Expandgravatar.test001
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.test39N/A

All

Test nameMinorCriticalNormal
Expandgravatar.admin.inc003
MessageGroupFilenameLineFunctionStatus
Use the matching Drupal theme functions, not raw HTML.Othergravatar.admin.inc36N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othergravatar.admin.inc66N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.admin.inc82N/A
Expandgravatar.author-pane.inc103
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc12N/A
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc13N/A
Separate comments from comment syntax by a space.Othergravatar.author-pane.inc14N/A
There should be no trailing spacesOthergravatar.author-pane.inc15N/A
Expandgravatar.install015
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othergravatar.install43N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install57N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install63N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install71N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install78N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.install87N/A
Expandgravatar.module0314
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.module89N/A
Separate comments from comment syntax by a space.Othergravatar.module91N/A
Separate comments from comment syntax by a space.Othergravatar.module92N/A
Separate comments from comment syntax by a space.Othergravatar.module93N/A
Separate comments from comment syntax by a space.Othergravatar.module94N/A
Separate comments from comment syntax by a space.Othergravatar.module95N/A
Function summaries should be one line only. (Drupal Docs)Othergravatar.module120N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module234N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module255N/A
Use the matching Drupal theme functions, not raw HTML.Othergravatar.module264N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othergravatar.module269N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othergravatar.module298N/A
Separate comments from comment syntax by a space.Othergravatar.module313N/A
Separate comments from comment syntax by a space.Othergravatar.module321N/A
Separate comments from comment syntax by a space.Othergravatar.module387N/A
Potential problem: trigger_error() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergravatar.module397N/A
Potential problem: trigger_error() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergravatar.module455N/A
Expandgravatar.test001
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othergravatar.test39N/A