One Click Upload - 7.x-1.x

Test status
StatusResult
Last receivedSun, 12/25/2011 - 15:46:37
Last requestedSun, 12/25/2011 - 15:47:03
Last testedSun, 12/25/2011 - 15:47:26
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectOne Click Upload
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 19 minor(s), 0 critical(s), and 26 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
19 minor(s), 0 critical(s), and 26 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandocupload.drush.inc501
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherocupload.drush.inc-1N/A
There should be no trailing spacesOtherocupload.drush.inc21N/A
There should be no trailing spacesOtherocupload.drush.inc27N/A
There should be no trailing spacesOtherocupload.drush.inc29N/A
There should be no trailing spacesOtherocupload.drush.inc38N/A
There should be no trailing spacesOtherocupload.drush.inc45N/A
Expandocupload.inc909
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherocupload.inc12N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.inc62N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.inc63N/A
There should be no trailing spacesOtherocupload.inc103N/A
There should be no trailing spacesOtherocupload.inc181N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherocupload.inc184N/A
There should be no trailing spacesOtherocupload.inc234N/A
There should be no trailing spacesOtherocupload.inc247N/A
There should be no trailing spacesOtherocupload.inc249N/A
There should be no trailing spacesOtherocupload.inc253N/A
There should be no trailing spacesOtherocupload.inc310N/A
Use Drupal's format_date(), not PHP's default date().Otherocupload.inc311N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherocupload.inc353N/A
do not use mixed case (camelCase), use lower case and _Otherocupload.inc367N/A
do not use mixed case (camelCase), use lower case and _Otherocupload.inc368N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherocupload.inc417N/A
Function summaries should be one line only. (Drupal Docs)Otherocupload.inc422N/A
Function documentation should be less than 80 characters per line.Otherocupload.inc423N/A
Expandocupload.install308
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherocupload.install15N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install40N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install47N/A
There should be no trailing spacesOtherocupload.install96N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install101N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install102N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install112N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install113N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install120N/A
There should be no trailing spacesOtherocupload.install124N/A
There should be no trailing spacesOtherocupload.install129N/A
Expandocupload.module208
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Otherocupload.module20N/A
Administrative menu items should have a description.Otherocupload.module29N/A
Administrative menu items should have a description.Otherocupload.module38N/A
Use "elseif" in place of "else if"Otherocupload.module93N/A
Use "elseif" not "else if".Otherocupload.module93N/A
Use "elseif" in place of "else if"Otherocupload.module96N/A
Use "elseif" not "else if".Otherocupload.module96N/A
Function summaries should be one line only. (Drupal Docs)Otherocupload.module139N/A
Format should be * Implementation of hook_foo().Otherocupload.module191N/A
Format should be * Implementation of hook_foo().Otherocupload.module207N/A

All

Test nameMinorCriticalNormal
Expandocupload.drush.inc501
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherocupload.drush.inc-1N/A
There should be no trailing spacesOtherocupload.drush.inc21N/A
There should be no trailing spacesOtherocupload.drush.inc27N/A
There should be no trailing spacesOtherocupload.drush.inc29N/A
There should be no trailing spacesOtherocupload.drush.inc38N/A
There should be no trailing spacesOtherocupload.drush.inc45N/A
Expandocupload.inc909
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherocupload.inc12N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.inc62N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.inc63N/A
There should be no trailing spacesOtherocupload.inc103N/A
There should be no trailing spacesOtherocupload.inc181N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherocupload.inc184N/A
There should be no trailing spacesOtherocupload.inc234N/A
There should be no trailing spacesOtherocupload.inc247N/A
There should be no trailing spacesOtherocupload.inc249N/A
There should be no trailing spacesOtherocupload.inc253N/A
There should be no trailing spacesOtherocupload.inc310N/A
Use Drupal's format_date(), not PHP's default date().Otherocupload.inc311N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherocupload.inc353N/A
do not use mixed case (camelCase), use lower case and _Otherocupload.inc367N/A
do not use mixed case (camelCase), use lower case and _Otherocupload.inc368N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherocupload.inc417N/A
Function summaries should be one line only. (Drupal Docs)Otherocupload.inc422N/A
Function documentation should be less than 80 characters per line.Otherocupload.inc423N/A
Expandocupload.install308
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherocupload.install15N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install40N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install47N/A
There should be no trailing spacesOtherocupload.install96N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install101N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install102N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install112N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install113N/A
Use the matching Drupal theme functions, not raw HTML.Otherocupload.install120N/A
There should be no trailing spacesOtherocupload.install124N/A
There should be no trailing spacesOtherocupload.install129N/A
Expandocupload.module208
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Otherocupload.module20N/A
Administrative menu items should have a description.Otherocupload.module29N/A
Administrative menu items should have a description.Otherocupload.module38N/A
Use "elseif" in place of "else if"Otherocupload.module93N/A
Use "elseif" not "else if".Otherocupload.module93N/A
Use "elseif" in place of "else if"Otherocupload.module96N/A
Use "elseif" not "else if".Otherocupload.module96N/A
Function summaries should be one line only. (Drupal Docs)Otherocupload.module139N/A
Format should be * Implementation of hook_foo().Otherocupload.module191N/A
Format should be * Implementation of hook_foo().Otherocupload.module207N/A