Ad Flash - 6.x-2.8-beta2

Test status
StatusResult
Last receivedTue, 12/20/2011 - 14:58:37
Last requestedTue, 12/20/2011 - 14:59:14
Last testedTue, 12/20/2011 - 14:59:21
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.8-beta2
ProjectAd Flash
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 20 minor(s), 1 critical(s), and 110 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
20 minor(s), 1 critical(s), and 110 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandad_flash.install908
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherad_flash.install-1N/A
There should be no trailing spacesOtherad_flash.install9N/A
There should be no trailing spacesOtherad_flash.install12N/A
There should be no trailing spacesOtherad_flash.install17N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.install48N/A
There should be no trailing spacesOtherad_flash.install90N/A
There should be no trailing spacesOtherad_flash.install97N/A
There should be no trailing spacesOtherad_flash.install104N/A
There should be no trailing spacesOtherad_flash.install115N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install130N/A
There should be no trailing spacesOtherad_flash.install130N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install131N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install136N/A
There should be no trailing spacesOtherad_flash.install136N/A
Function summaries should be one line only. (Drupal Docs)Otherad_flash.install142N/A
Function documentation should be less than 80 characters per line.Otherad_flash.install143N/A
the final ?> should be omitted from all code filesOtherad_flash.install151N/A
Expandad_flash.module6198
MessageGroupFilenameLineFunctionStatus
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module25N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module61N/A
Separate comments from comment syntax by a space.Otherad_flash.module63N/A
Function summaries should be one line only. (Drupal Docs)Otherad_flash.module73N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module75N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module76N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module82N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module121N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module187N/A
Doxygen uses @todo and @bug to markup things to be done.Otherad_flash.module190N/A
Separate comments from comment syntax by a space.Otherad_flash.module193N/A
else statements should begin on a new lineOtherad_flash.module195N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module200N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module206N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module240N/A
else statements should begin on a new lineOtherad_flash.module245N/A
else statements should begin on a new lineOtherad_flash.module252N/A
Use "elseif" in place of "else if"Otherad_flash.module252N/A
Use "elseif" not "else if".Otherad_flash.module252N/A
else statements should begin on a new lineOtherad_flash.module256N/A
else statements should begin on a new lineOtherad_flash.module263N/A
else statements should begin on a new lineOtherad_flash.module273N/A
Use "elseif" in place of "else if"Otherad_flash.module273N/A
Use "elseif" not "else if".Otherad_flash.module273N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherad_flash.module317N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module329N/A
else statements should begin on a new lineOtherad_flash.module337N/A
Use "elseif" in place of "else if"Otherad_flash.module337N/A
Use "elseif" not "else if".Otherad_flash.module337N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module356N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module368N/A
Doxygen uses @todo and @bug to markup things to be done.Otherad_flash.module373N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module388N/A
else statements should begin on a new lineOtherad_flash.module393N/A
Use "elseif" in place of "else if"Otherad_flash.module393N/A
Use "elseif" not "else if".Otherad_flash.module393N/A
else statements should begin on a new lineOtherad_flash.module400N/A
Use "elseif" in place of "else if"Otherad_flash.module400N/A
Use "elseif" not "else if".Otherad_flash.module400N/A
else statements should begin on a new lineOtherad_flash.module410N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module412N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherad_flash.module412N/A
else statements should begin on a new lineOtherad_flash.module416N/A
Remove the empty commented line in your function documentation.Otherad_flash.module422N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module424N/A
Remove the empty commented line in your function documentation.Otherad_flash.module428N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module430N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module438N/A
else statements should begin on a new lineOtherad_flash.module442N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module447N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module460N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.module467N/A
else statements should begin on a new lineOtherad_flash.module473N/A
Use PHP's master function, not an alias.Otherad_flash.module476N/A
Separate comments from comment syntax by a space.Otherad_flash.module486N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module491N/A
else statements should begin on a new lineOtherad_flash.module496N/A
Use "elseif" in place of "else if"Otherad_flash.module496N/A
Use "elseif" not "else if".Otherad_flash.module496N/A
else statements should begin on a new lineOtherad_flash.module498N/A
Separate comments from comment syntax by a space.Otherad_flash.module501N/A
else statements should begin on a new lineOtherad_flash.module502N/A
Use "elseif" in place of "else if"Otherad_flash.module502N/A
Use "elseif" not "else if".Otherad_flash.module502N/A
Separate comments from comment syntax by a space.Otherad_flash.module526N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.module528N/A
Separate comments from comment syntax by a space.Otherad_flash.module529N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module538N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module546N/A
Use "elseif" in place of "else if"Otherad_flash.module555N/A
Use "elseif" not "else if".Otherad_flash.module555N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module567N/A
Separate comments from comment syntax by a space.Otherad_flash.module569N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module575N/A
Separate comments from comment syntax by a space.Otherad_flash.module577N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module578N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module586N/A
curly braces { should end a line, not start oneOtherad_flash.module586N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module587N/A
Control statements should have one space between the control keyword and opening parenthesisOtherad_flash.module587N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module587N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module589N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module590N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module591N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module592N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module594N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module597N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash.module597N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module603N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module603N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module604N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module605N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module605N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module606N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module607N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module607N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module608N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module608N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module609N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module613N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module615N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module618N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module619N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module621N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module626N/A
Expandad_flash_views.inc504
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherad_flash_views.inc10N/A
There should be no trailing spacesOtherad_flash_views.inc11N/A
There should be no trailing spacesOtherad_flash_views.inc13N/A
There should be no trailing spacesOtherad_flash_views.inc17N/A
There should be no trailing spacesOtherad_flash_views.inc18N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash_views.inc69N/A
Use "elseif" in place of "else if"Otherad_flash_views.inc72N/A
Use "elseif" not "else if".Otherad_flash_views.inc72N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash_views.inc76N/A

All

Test nameMinorCriticalNormal
Expandad_flash.install908
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherad_flash.install-1N/A
There should be no trailing spacesOtherad_flash.install9N/A
There should be no trailing spacesOtherad_flash.install12N/A
There should be no trailing spacesOtherad_flash.install17N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.install48N/A
There should be no trailing spacesOtherad_flash.install90N/A
There should be no trailing spacesOtherad_flash.install97N/A
There should be no trailing spacesOtherad_flash.install104N/A
There should be no trailing spacesOtherad_flash.install115N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install130N/A
There should be no trailing spacesOtherad_flash.install130N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install131N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.install136N/A
There should be no trailing spacesOtherad_flash.install136N/A
Function summaries should be one line only. (Drupal Docs)Otherad_flash.install142N/A
Function documentation should be less than 80 characters per line.Otherad_flash.install143N/A
the final ?> should be omitted from all code filesOtherad_flash.install151N/A
Expandad_flash.module6198
MessageGroupFilenameLineFunctionStatus
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module25N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module61N/A
Separate comments from comment syntax by a space.Otherad_flash.module63N/A
Function summaries should be one line only. (Drupal Docs)Otherad_flash.module73N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module75N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module76N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module82N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module121N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module187N/A
Doxygen uses @todo and @bug to markup things to be done.Otherad_flash.module190N/A
Separate comments from comment syntax by a space.Otherad_flash.module193N/A
else statements should begin on a new lineOtherad_flash.module195N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module200N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module206N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module240N/A
else statements should begin on a new lineOtherad_flash.module245N/A
else statements should begin on a new lineOtherad_flash.module252N/A
Use "elseif" in place of "else if"Otherad_flash.module252N/A
Use "elseif" not "else if".Otherad_flash.module252N/A
else statements should begin on a new lineOtherad_flash.module256N/A
else statements should begin on a new lineOtherad_flash.module263N/A
else statements should begin on a new lineOtherad_flash.module273N/A
Use "elseif" in place of "else if"Otherad_flash.module273N/A
Use "elseif" not "else if".Otherad_flash.module273N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherad_flash.module317N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module329N/A
else statements should begin on a new lineOtherad_flash.module337N/A
Use "elseif" in place of "else if"Otherad_flash.module337N/A
Use "elseif" not "else if".Otherad_flash.module337N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module356N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module368N/A
Doxygen uses @todo and @bug to markup things to be done.Otherad_flash.module373N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module388N/A
else statements should begin on a new lineOtherad_flash.module393N/A
Use "elseif" in place of "else if"Otherad_flash.module393N/A
Use "elseif" not "else if".Otherad_flash.module393N/A
else statements should begin on a new lineOtherad_flash.module400N/A
Use "elseif" in place of "else if"Otherad_flash.module400N/A
Use "elseif" not "else if".Otherad_flash.module400N/A
else statements should begin on a new lineOtherad_flash.module410N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherad_flash.module412N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherad_flash.module412N/A
else statements should begin on a new lineOtherad_flash.module416N/A
Remove the empty commented line in your function documentation.Otherad_flash.module422N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module424N/A
Remove the empty commented line in your function documentation.Otherad_flash.module428N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module430N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module438N/A
else statements should begin on a new lineOtherad_flash.module442N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module447N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module460N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.module467N/A
else statements should begin on a new lineOtherad_flash.module473N/A
Use PHP's master function, not an alias.Otherad_flash.module476N/A
Separate comments from comment syntax by a space.Otherad_flash.module486N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module491N/A
else statements should begin on a new lineOtherad_flash.module496N/A
Use "elseif" in place of "else if"Otherad_flash.module496N/A
Use "elseif" not "else if".Otherad_flash.module496N/A
else statements should begin on a new lineOtherad_flash.module498N/A
Separate comments from comment syntax by a space.Otherad_flash.module501N/A
else statements should begin on a new lineOtherad_flash.module502N/A
Use "elseif" in place of "else if"Otherad_flash.module502N/A
Use "elseif" not "else if".Otherad_flash.module502N/A
Separate comments from comment syntax by a space.Otherad_flash.module526N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherad_flash.module528N/A
Separate comments from comment syntax by a space.Otherad_flash.module529N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module538N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module546N/A
Use "elseif" in place of "else if"Otherad_flash.module555N/A
Use "elseif" not "else if".Otherad_flash.module555N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module567N/A
Separate comments from comment syntax by a space.Otherad_flash.module569N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherad_flash.module575N/A
Separate comments from comment syntax by a space.Otherad_flash.module577N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module578N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module586N/A
curly braces { should end a line, not start oneOtherad_flash.module586N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module587N/A
Control statements should have one space between the control keyword and opening parenthesisOtherad_flash.module587N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module587N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module589N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module590N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module591N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module592N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module594N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module597N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash.module597N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module603N/A
use a space between the closing parenthesis and the open bracketOtherad_flash.module603N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module604N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module605N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module605N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module606N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module607N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module607N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module608N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherad_flash.module608N/A
Use an indent of 2 spaces, with no tabsOtherad_flash.module609N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module613N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module615N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module618N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module619N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherad_flash.module621N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherad_flash.module626N/A
Expandad_flash_views.inc504
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherad_flash_views.inc10N/A
There should be no trailing spacesOtherad_flash_views.inc11N/A
There should be no trailing spacesOtherad_flash_views.inc13N/A
There should be no trailing spacesOtherad_flash_views.inc17N/A
There should be no trailing spacesOtherad_flash_views.inc18N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash_views.inc69N/A
Use "elseif" in place of "else if"Otherad_flash_views.inc72N/A
Use "elseif" not "else if".Otherad_flash_views.inc72N/A
Use the matching Drupal theme functions, not raw HTML.Otherad_flash_views.inc76N/A