Settings Menu Link - 7.x-1.0

Test status
StatusResult
Last receivedSat, 12/17/2011 - 18:02:22
Last requestedSat, 12/17/2011 - 18:03:03
Last testedSat, 12/17/2011 - 18:03:28
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.0
ProjectSettings Menu Link
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 1 minor(s), 1 critical(s), and 6 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
1 minor(s), 1 critical(s), and 6 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandsettings_menu_link.module114
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersettings_menu_link.module-1N/A
Administrative menu items should have a description.Othersettings_menu_link.module8N/A
Functions should be called with no spaces between the function name and opening parenthesesOthersettings_menu_link.module142N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersettings_menu_link.module181N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othersettings_menu_link.module188N/A
Use Drupal's format_date(), not PHP's default date().Othersettings_menu_link.module201N/A
Expandsettings_menu_link.overview.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersettings_menu_link.overview.inc-1N/A
Control statements should have one space between the control keyword and opening parenthesisOthersettings_menu_link.overview.inc26N/A

All

Test nameMinorCriticalNormal
Expandsettings_menu_link.module114
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersettings_menu_link.module-1N/A
Administrative menu items should have a description.Othersettings_menu_link.module8N/A
Functions should be called with no spaces between the function name and opening parenthesesOthersettings_menu_link.module142N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersettings_menu_link.module181N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othersettings_menu_link.module188N/A
Use Drupal's format_date(), not PHP's default date().Othersettings_menu_link.module201N/A
Expandsettings_menu_link.overview.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersettings_menu_link.overview.inc-1N/A
Control statements should have one space between the control keyword and opening parenthesisOthersettings_menu_link.overview.inc26N/A