Kerberos Authentication - 6.x-2.0-alpha1

Test status
StatusResult
Last receivedSun, 12/04/2011 - 21:21:37
Last requestedSun, 12/04/2011 - 21:21:56
Last testedSun, 12/04/2011 - 21:22:03
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.0-alpha1
ProjectKerberos Authentication
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 14 minor(s), 1 critical(s), and 40 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
14 minor(s), 1 critical(s), and 40 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandincludes/krb5_functions.inc10014
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc11N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc40N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc40N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc41N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc41N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc42N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc42N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc45N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc45N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc46N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc46N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc47N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherkrb5_functions.inc47N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc47N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc48N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc49N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc50N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc51N/A
use a space between the closing parenthesis and the open bracketOtherkrb5_functions.inc51N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc53N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc54N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc54N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc55N/A
missing space after commaOtherkrb5_functions.inc56N/A
Expandkerberos_authentication.admin.inc105
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.admin.inc8N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherkerberos_authentication.admin.inc53N/A
Use an indent of 2 spaces, with no tabsOtherkerberos_authentication.admin.inc192N/A
Use Drupal's format_date(), not PHP's default date().Otherkerberos_authentication.admin.inc203N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.admin.inc243N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.admin.inc261N/A
Expandkerberos_authentication.install003
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.install8N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.install32N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.install70N/A
Expandkerberos_authentication.module3116
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.module8N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module20N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherkerberos_authentication.module68N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherkerberos_authentication.module140N/A
Use an indent of 2 spaces, with no tabsOtherkerberos_authentication.module186N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module186N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module217N/A
Use Drupal's format_date(), not PHP's default date().Otherkerberos_authentication.module225N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherkerberos_authentication.module283N/A
There should be no trailing spacesOtherkerberos_authentication.module283N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherkerberos_authentication.module285N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherkerberos_authentication.module287N/A
missing space after commaOtherkerberos_authentication.module287N/A
Use "elseif" in place of "else if"Otherkerberos_authentication.module290N/A
Use "elseif" not "else if".Otherkerberos_authentication.module290N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.module337N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module348N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module356N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module362N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.module371N/A
Expandkerberos_authentication.theme.inc002
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.theme.inc7N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.theme.inc8N/A

All

Test nameMinorCriticalNormal
Expandincludes/krb5_functions.inc10014
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc11N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc40N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc40N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc41N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc41N/A
If you define a @param or @return, you should document it as well.Otherkrb5_functions.inc42N/A
@param and @return syntax does not indicate the data type. (Drupal Docs)Otherkrb5_functions.inc42N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc45N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc45N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc46N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc46N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc47N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherkrb5_functions.inc47N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc47N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc48N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc49N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc50N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc51N/A
use a space between the closing parenthesis and the open bracketOtherkrb5_functions.inc51N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc53N/A
Use an indent of 2 spaces, with no tabsOtherkrb5_functions.inc54N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc54N/A
Separate comments from comment syntax by a space.Otherkrb5_functions.inc55N/A
missing space after commaOtherkrb5_functions.inc56N/A
Expandkerberos_authentication.admin.inc105
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.admin.inc8N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherkerberos_authentication.admin.inc53N/A
Use an indent of 2 spaces, with no tabsOtherkerberos_authentication.admin.inc192N/A
Use Drupal's format_date(), not PHP's default date().Otherkerberos_authentication.admin.inc203N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.admin.inc243N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.admin.inc261N/A
Expandkerberos_authentication.install003
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.install8N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.install32N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.install70N/A
Expandkerberos_authentication.module3116
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.module8N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module20N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherkerberos_authentication.module68N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherkerberos_authentication.module140N/A
Use an indent of 2 spaces, with no tabsOtherkerberos_authentication.module186N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module186N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module217N/A
Use Drupal's format_date(), not PHP's default date().Otherkerberos_authentication.module225N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherkerberos_authentication.module283N/A
There should be no trailing spacesOtherkerberos_authentication.module283N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherkerberos_authentication.module285N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherkerberos_authentication.module287N/A
missing space after commaOtherkerberos_authentication.module287N/A
Use "elseif" in place of "else if"Otherkerberos_authentication.module290N/A
Use "elseif" not "else if".Otherkerberos_authentication.module290N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.module337N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module348N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module356N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.module362N/A
If you define a @param or @return, you should document it as well.Otherkerberos_authentication.module371N/A
Expandkerberos_authentication.theme.inc002
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Otherkerberos_authentication.theme.inc7N/A
Separate comments from comment syntax by a space.Otherkerberos_authentication.theme.inc8N/A