Taskbar - 6.x-1.x

Test status
StatusResult
Last receivedThu, 04/05/2012 - 10:30:55
Last requestedThu, 04/05/2012 - 10:31:27
Last testedThu, 04/05/2012 - 10:31:51
Test count3
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectTaskbar
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 29 minor(s), 6 critical(s), and 51 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
29 minor(s), 6 critical(s), and 51 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandexamples/taskbar_activity_example/taskbar_activity_example.module002
MessageGroupFilenameLineFunctionStatus
missing space after commaOthertaskbar_activity_example.module26N/A
missing space after commaOthertaskbar_activity_example.module32N/A
Expandincludes/taskbar.theme.inc004
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othertaskbar.theme.inc-1N/A
Separate comments from comment syntax by a space.Othertaskbar.theme.inc2N/A
Separate comments from comment syntax by a space.Othertaskbar.theme.inc4N/A
The control statement should be on a separate line from the control conditionalOthertaskbar.theme.inc28N/A
Expandmodules/taskbar_activity/taskbar_activity.admin.inc101
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_activity.admin.inc57N/A
missing space after commaOthertaskbar_activity.admin.inc80N/A
Expandmodules/taskbar_migrate/taskbar_migrate.module110
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Othertaskbar_migrate.module77N/A
There should be no trailing spacesOthertaskbar_migrate.module84N/A
Expandmodules/taskbar_tacore/taskbar_tacore.api.php004
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php15N/A
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php20N/A
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php21N/A
Remove the empty commented line in your function documentation.Othertaskbar_tacore.api.php25N/A
Expandmodules/taskbar_tacore/taskbar_tacore.module014
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othertaskbar_tacore.module50N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module52N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othertaskbar_tacore.module61N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module82N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module84N/A
Expandmodules/taskbar_ui/taskbar_ui-list-form.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthertaskbar_ui-list-form.tpl.php69N/A
Expandmodules/taskbar_ui/taskbar_ui.module349
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Othertaskbar_ui.module69N/A
Administrative menu items should have a description.Othertaskbar_ui.module76N/A
Administrative menu items should have a description.Othertaskbar_ui.module83N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module92N/A
There should be no trailing spacesOthertaskbar_ui.module93N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module94N/A
There should be no trailing spacesOthertaskbar_ui.module280N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_ui.module436N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_ui.module445N/A
Function documentation should be less than 80 characters per line.Othertaskbar_ui.module453N/A
Function documentation should be less than 80 characters per line.Othertaskbar_ui.module454N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Othertaskbar_ui.module497N/A
Use an indent of 2 spaces, with no tabsOthertaskbar_ui.module555N/A
table names should be enclosed in {curly_brackets}Othertaskbar_ui.module564N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module606N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module608N/A
Expandmodules/taskbar_views/taskbar_views.admin.inc201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othertaskbar_views.admin.inc-1N/A
There should be no trailing spacesOthertaskbar_views.admin.inc11N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_views.admin.inc67N/A
Expandmodules/taskbar_views/taskbar_views.module003
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Othertaskbar_views.module117N/A
If you define a @param or @return, you should document it as well.Othertaskbar_views.module118N/A
If you define a @param or @return, you should document it as well.Othertaskbar_views.module119N/A
Expandtaskbar.api.php108
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othertaskbar.api.php8N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php9N/A
There should be no trailing spacesOthertaskbar.api.php11N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php17N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php21N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php53N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php58N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php59N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.api.php129N/A
Expandtaskbar.install1101
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar.install16N/A
There should be no trailing spacesOthertaskbar.install17N/A
There should be no trailing spacesOthertaskbar.install22N/A
There should be no trailing spacesOthertaskbar.install23N/A
There should be no trailing spacesOthertaskbar.install47N/A
There should be no trailing spacesOthertaskbar.install48N/A
There should be no trailing spacesOthertaskbar.install53N/A
There should be no trailing spacesOthertaskbar.install54N/A
There should be no trailing spacesOthertaskbar.install59N/A
There should be no trailing spacesOthertaskbar.install60N/A
Use update_sql() instead of db_query() in hook_update_N()Othertaskbar.install140N/A
There should be no trailing spacesOthertaskbar.install154N/A
Expandtaskbar.module0012
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othertaskbar.module123N/A
Separate comments from comment syntax by a space.Othertaskbar.module125N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module145N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module173N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module188N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module247N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module522N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module597N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module598N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.module598N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module599N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.module599N/A
Expandtaskbar.taskbar.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othertaskbar.taskbar.inc66N/A

All

Test nameMinorCriticalNormal
Leafexamples/taskbar_activity_example/taskbar_activity_example.install000
Expandexamples/taskbar_activity_example/taskbar_activity_example.module002
MessageGroupFilenameLineFunctionStatus
missing space after commaOthertaskbar_activity_example.module26N/A
missing space after commaOthertaskbar_activity_example.module32N/A
Expandincludes/taskbar.theme.inc004
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othertaskbar.theme.inc-1N/A
Separate comments from comment syntax by a space.Othertaskbar.theme.inc2N/A
Separate comments from comment syntax by a space.Othertaskbar.theme.inc4N/A
The control statement should be on a separate line from the control conditionalOthertaskbar.theme.inc28N/A
Expandmodules/taskbar_activity/taskbar_activity.admin.inc101
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_activity.admin.inc57N/A
missing space after commaOthertaskbar_activity.admin.inc80N/A
Leafmodules/taskbar_activity/taskbar_activity.api.php000
Leafmodules/taskbar_activity/taskbar_activity.install000
Leafmodules/taskbar_activity/taskbar_activity.module000
Expandmodules/taskbar_migrate/taskbar_migrate.module110
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Othertaskbar_migrate.module77N/A
There should be no trailing spacesOthertaskbar_migrate.module84N/A
Expandmodules/taskbar_tacore/taskbar_tacore.api.php004
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php15N/A
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php20N/A
Function documentation should be less than 80 characters per line.Othertaskbar_tacore.api.php21N/A
Remove the empty commented line in your function documentation.Othertaskbar_tacore.api.php25N/A
Expandmodules/taskbar_tacore/taskbar_tacore.install200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_tacore.install22N/A
There should be no trailing spacesOthertaskbar_tacore.install23N/A
Expandmodules/taskbar_tacore/taskbar_tacore.module014
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othertaskbar_tacore.module50N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module52N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othertaskbar_tacore.module61N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module82N/A
Separate comments from comment syntax by a space.Othertaskbar_tacore.module84N/A
Expandmodules/taskbar_ui/taskbar_ui-list-form.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthertaskbar_ui-list-form.tpl.php69N/A
Expandmodules/taskbar_ui/taskbar_ui.module349
MessageGroupFilenameLineFunctionStatus
Administrative menu items should have a description.Othertaskbar_ui.module69N/A
Administrative menu items should have a description.Othertaskbar_ui.module76N/A
Administrative menu items should have a description.Othertaskbar_ui.module83N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module92N/A
There should be no trailing spacesOthertaskbar_ui.module93N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module94N/A
There should be no trailing spacesOthertaskbar_ui.module280N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_ui.module436N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_ui.module445N/A
Function documentation should be less than 80 characters per line.Othertaskbar_ui.module453N/A
Function documentation should be less than 80 characters per line.Othertaskbar_ui.module454N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Othertaskbar_ui.module497N/A
Use an indent of 2 spaces, with no tabsOthertaskbar_ui.module555N/A
table names should be enclosed in {curly_brackets}Othertaskbar_ui.module564N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module606N/A
Separate comments from comment syntax by a space.Othertaskbar_ui.module608N/A
Expandmodules/taskbar_views/taskbar_views.admin.inc201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othertaskbar_views.admin.inc-1N/A
There should be no trailing spacesOthertaskbar_views.admin.inc11N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othertaskbar_views.admin.inc67N/A
Expandmodules/taskbar_views/taskbar_views.install100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_views.install31N/A
Expandmodules/taskbar_views/taskbar_views.module003
MessageGroupFilenameLineFunctionStatus
Function summaries should be one line only. (Drupal Docs)Othertaskbar_views.module117N/A
If you define a @param or @return, you should document it as well.Othertaskbar_views.module118N/A
If you define a @param or @return, you should document it as well.Othertaskbar_views.module119N/A
Expandproviders/taskbar_provider.block.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_provider.block.inc47N/A
Expandproviders/taskbar_provider.custom.inc500
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_provider.custom.inc42N/A
There should be no trailing spacesOthertaskbar_provider.custom.inc53N/A
There should be no trailing spacesOthertaskbar_provider.custom.inc54N/A
There should be no trailing spacesOthertaskbar_provider.custom.inc55N/A
There should be no trailing spacesOthertaskbar_provider.custom.inc56N/A
Expandproviders/taskbar_provider.link.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar_provider.link.inc40N/A
Expandtaskbar.api.php108
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othertaskbar.api.php8N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php9N/A
There should be no trailing spacesOthertaskbar.api.php11N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php17N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php21N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php53N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php58N/A
Function documentation should be less than 80 characters per line.Othertaskbar.api.php59N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.api.php129N/A
Expandtaskbar.install1101
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthertaskbar.install16N/A
There should be no trailing spacesOthertaskbar.install17N/A
There should be no trailing spacesOthertaskbar.install22N/A
There should be no trailing spacesOthertaskbar.install23N/A
There should be no trailing spacesOthertaskbar.install47N/A
There should be no trailing spacesOthertaskbar.install48N/A
There should be no trailing spacesOthertaskbar.install53N/A
There should be no trailing spacesOthertaskbar.install54N/A
There should be no trailing spacesOthertaskbar.install59N/A
There should be no trailing spacesOthertaskbar.install60N/A
Use update_sql() instead of db_query() in hook_update_N()Othertaskbar.install140N/A
There should be no trailing spacesOthertaskbar.install154N/A
Expandtaskbar.module0012
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othertaskbar.module123N/A
Separate comments from comment syntax by a space.Othertaskbar.module125N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module145N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module173N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module188N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module247N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module522N/A
Function summaries should be one line only. (Drupal Docs)Othertaskbar.module597N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module598N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.module598N/A
If you define a @param or @return, you should document it as well.Othertaskbar.module599N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Othertaskbar.module599N/A
Expandtaskbar.taskbar.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othertaskbar.taskbar.inc66N/A