Role Expire - 7.x-1.x

Test status
StatusResult
Last receivedMon, 04/09/2012 - 16:03:41
Last requestedMon, 04/09/2012 - 16:04:03
Last testedMon, 04/09/2012 - 16:04:49
Test count7
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-1.x
ProjectRole Expire
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 26 minor(s), 0 critical(s), and 64 normal(s); [[SimpleTest]]: [MySQL] 80 pass(es), 9 fail(s), and 1 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
80 pass(es), 9 fail(s), and 1 exception(s)

Non-pass

Test namePassFailException
ExpandRole Expire web tests (RoleExpireWebTestCase) [Role Expire]8091
MessageGroupFilenameLineFunctionStatus
Making sure role checkbox is still on page.Otherrole_expire.test119RoleExpireWebTestCase->testRoleExpire_tests()
Testing aborted before completion: checkbox missing.Otherrole_expire.test121RoleExpireWebTestCase->testRoleExpire_tests()
Failed to set field roles[2] to 2Otherrole_expire.test171RoleExpireWebTestCase->testAssignAndRemoveRole()
Found the requested form fields at user/4/editOtherrole_expire.test171RoleExpireWebTestCase->testAssignAndRemoveRole()
"The changes have been saved." foundOtherrole_expire.test172RoleExpireWebTestCase->testAssignAndRemoveRole()
Role is assigned.Browserrole_expire.test173RoleExpireWebTestCase->testAssignAndRemoveRole()
Failed to set field roles[2] to Otherrole_expire.test176RoleExpireWebTestCase->testAssignAndRemoveRole()
Found the requested form fields at user/4/editOtherrole_expire.test176RoleExpireWebTestCase->testAssignAndRemoveRole()
"The changes have been saved." foundOtherrole_expire.test177RoleExpireWebTestCase->testAssignAndRemoveRole()
Role is removed from user.Browserrole_expire.test178RoleExpireWebTestCase->testAssignAndRemoveRole()

All

Test namePassFailException
ExpandRole Expire web tests (RoleExpireWebTestCase) [Role Expire]8091
MessageGroupFilenameLineFunctionStatus
Making sure role checkbox is still on page.Otherrole_expire.test119RoleExpireWebTestCase->testRoleExpire_tests()
Testing aborted before completion: checkbox missing.Otherrole_expire.test121RoleExpireWebTestCase->testRoleExpire_tests()
Failed to set field roles[2] to 2Otherrole_expire.test171RoleExpireWebTestCase->testAssignAndRemoveRole()
Found the requested form fields at user/4/editOtherrole_expire.test171RoleExpireWebTestCase->testAssignAndRemoveRole()
"The changes have been saved." foundOtherrole_expire.test172RoleExpireWebTestCase->testAssignAndRemoveRole()
Role is assigned.Browserrole_expire.test173RoleExpireWebTestCase->testAssignAndRemoveRole()
Failed to set field roles[2] to Otherrole_expire.test176RoleExpireWebTestCase->testAssignAndRemoveRole()
Found the requested form fields at user/4/editOtherrole_expire.test176RoleExpireWebTestCase->testAssignAndRemoveRole()
"The changes have been saved." foundOtherrole_expire.test177RoleExpireWebTestCase->testAssignAndRemoveRole()
Role is removed from user.Browserrole_expire.test178RoleExpireWebTestCase->testAssignAndRemoveRole()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
26 minor(s), 0 critical(s), and 64 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandrole_expire.module18023
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherrole_expire.module13N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module16N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module21N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module30N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module33N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module52N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module65N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module88N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module90N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module91N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module92N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module93N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module108N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module111N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.module112N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module132N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module134N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module135N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module136N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module150N/A
put a space between the asterisk and the comment textOtherrole_expire.module181N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module253N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module257N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module269N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherrole_expire.module283N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module301N/A
There should be no trailing spacesOtherrole_expire.module372N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module373N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module392N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module418N/A
Format should be * Implementation of hook_foo().Otherrole_expire.module427N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letterOtherrole_expire.module427N/A
missing space after commaOtherrole_expire.module445N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module479N/A
put a space between the asterisk and the comment textOtherrole_expire.module492N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module495N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module514N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module515N/A
curly braces { should end a line, not start oneOtherrole_expire.module534N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module547N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module562N/A
Expandrole_expire.rules.inc202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrole_expire.rules.inc106N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc106N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_expire.rules.inc112N/A
There should be no trailing spacesOtherrole_expire.rules.inc113N/A
Expandrole_expire.views.inc203
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherrole_expire.views.inc11N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.views.inc16N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherrole_expire.views.inc19N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherrole_expire.views.inc19N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.views.inc112N/A
Expandtests/role_expire.test2036
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherrole_expire.test-1N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test36N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test40N/A
missing space after commaOtherrole_expire.test40N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test42N/A
missing space after commaOtherrole_expire.test42N/A
missing space after commaOtherrole_expire.test65N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test69N/A
missing space after commaOtherrole_expire.test69N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test70N/A
missing space after commaOtherrole_expire.test71N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.test75N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.test76N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test81N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test82N/A
missing space after commaOtherrole_expire.test85N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.test85N/A
missing space after commaOtherrole_expire.test87N/A
missing space after commaOtherrole_expire.test88N/A
missing space after commaOtherrole_expire.test93N/A
missing space after commaOtherrole_expire.test94N/A
missing space after commaOtherrole_expire.test99N/A
missing space after commaOtherrole_expire.test100N/A
missing space after commaOtherrole_expire.test103N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.test103N/A
missing space after commaOtherrole_expire.test105N/A
missing space after commaOtherrole_expire.test106N/A
missing space after commaOtherrole_expire.test107N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.test114N/A
missing space after commaOtherrole_expire.test118N/A
missing space after commaOtherrole_expire.test119N/A
missing space after commaOtherrole_expire.test124N/A
missing space after commaOtherrole_expire.test134N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test135N/A
missing space after commaOtherrole_expire.test135N/A
missing space after commaOtherrole_expire.test136N/A
missing space after commaOtherrole_expire.test150N/A
missing space after commaOtherrole_expire.test159N/A

All

Test nameMinorCriticalNormal
Expandrole_expire.install200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrole_expire.install64N/A
There should be no trailing spacesOtherrole_expire.install71N/A
Leafrole_expire.migrate.inc000
Expandrole_expire.module18023
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherrole_expire.module13N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module16N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module21N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module30N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module33N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module52N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module65N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module88N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module90N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module91N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module92N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module93N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module108N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module111N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.module112N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module132N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module134N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module135N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module136N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module150N/A
put a space between the asterisk and the comment textOtherrole_expire.module181N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module253N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module257N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module269N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherrole_expire.module283N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module301N/A
There should be no trailing spacesOtherrole_expire.module372N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module373N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module392N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module418N/A
Format should be * Implementation of hook_foo().Otherrole_expire.module427N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letterOtherrole_expire.module427N/A
missing space after commaOtherrole_expire.module445N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module479N/A
put a space between the asterisk and the comment textOtherrole_expire.module492N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module495N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module514N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module515N/A
curly braces { should end a line, not start oneOtherrole_expire.module534N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module547N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module562N/A
Expandrole_expire.rules.inc202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrole_expire.rules.inc106N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc106N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_expire.rules.inc112N/A
There should be no trailing spacesOtherrole_expire.rules.inc113N/A
Expandrole_expire.views.inc203
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherrole_expire.views.inc11N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.views.inc16N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherrole_expire.views.inc19N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherrole_expire.views.inc19N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.views.inc112N/A
Expandtests/role_expire.test2036
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherrole_expire.test-1N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test36N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test40N/A
missing space after commaOtherrole_expire.test40N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test42N/A
missing space after commaOtherrole_expire.test42N/A
missing space after commaOtherrole_expire.test65N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test69N/A
missing space after commaOtherrole_expire.test69N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test70N/A
missing space after commaOtherrole_expire.test71N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.test75N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.test76N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test81N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.test82N/A
missing space after commaOtherrole_expire.test85N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.test85N/A
missing space after commaOtherrole_expire.test87N/A
missing space after commaOtherrole_expire.test88N/A
missing space after commaOtherrole_expire.test93N/A
missing space after commaOtherrole_expire.test94N/A
missing space after commaOtherrole_expire.test99N/A
missing space after commaOtherrole_expire.test100N/A
missing space after commaOtherrole_expire.test103N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.test103N/A
missing space after commaOtherrole_expire.test105N/A
missing space after commaOtherrole_expire.test106N/A
missing space after commaOtherrole_expire.test107N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.test114N/A
missing space after commaOtherrole_expire.test118N/A
missing space after commaOtherrole_expire.test119N/A
missing space after commaOtherrole_expire.test124N/A
missing space after commaOtherrole_expire.test134N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherrole_expire.test135N/A
missing space after commaOtherrole_expire.test135N/A
missing space after commaOtherrole_expire.test136N/A
missing space after commaOtherrole_expire.test150N/A
missing space after commaOtherrole_expire.test159N/A