ThemeKey - 7.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

ThemeKey - 7.x-2.x

Test status

Status	Result
Last received	Thu, 05/24/2012 - 07:56:47
Last requested	Thu, 05/24/2012 - 07:57:01
Last tested	Thu, 05/24/2012 - 08:04:10
Test count	3

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.x
Project	ThemeKey
Link	Project information

Event logView entire log

ID	Message	Timestamp
3802773	Result retrieved by project client.	3 years 39 weeks ago
3802733	Result received from test client #.	3 years 39 weeks ago
3802678	Result received from test client #.	3 years 39 weeks ago
3802623	Requested by test client #.	3 years 39 weeks ago
3802618	Requested by test client #.	3 years 39 weeks ago
3802613	Test request received.	3 years 39 weeks ago
3123848	Result retrieved by project client.	4 years 6 days ago
2563198	Result retrieved by project client.	4 years 14 weeks ago
2563188	Result retrieved by project client.	4 years 14 weeks ago
2563183	Result received from test client #.	4 years 14 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 127 minor(s), 1 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 286 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

286 pass(es), 0 fail(s), and 0 exception(s)

Test name

Pass

Fail

Exception

Themekey Drupal Properties (ThemekeyDrupalPropertiesTestCase) [Themekey]

Message	Group	Filename	Line	Function	Status
Testing Rule: 'drupal:is_front_page=true'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()

Themekey Multiple Node Properties (ThemekeyMultipleNodePropertiesTestCase) [Themekey]

Message	Group	Filename	Line	Function
array ( 'id' => '2', 'property' => 'node:uid', 'operator' => '=', 'value' => '1', 'weight' => '2', 'theme' => 'garland', 'enabled' => '1', 'wildcards' => 'a:0:{}', 'parent' => '1', 'module' => 'themekey', 'depth' => 1, )	Debug	ThemekeyMultipleNodePropertiesTestCase.test	67	ThemekeyMultipleNodePropertiesTestCase->testMultipleProperties()
array ( 'id' => '2', 'property' => 'node:uid', 'operator' => '=', 'value' => '1', 'weight' => '2', 'theme' => 'garland', 'enabled' => '1', 'wildcards' => array ( ), 'parent' => '1', 'module' => 'themekey', 'depth' => 1, )	Debug	ThemekeyMultipleNodePropertiesTestCase.test	69	ThemekeyMultipleNodePropertiesTestCase->testMultipleProperties()
Testing Rules: array ( 1 => array ( 'id' => '1', 'property' => 'node:title', 'operator' => '=', 'value' => 'Node title test', 'weight' => '1', 'theme' => 'garland', 'enabled' => '1', 'wildcards' => 'a:0:{}', 'parent' => '0', 'module' => 'themekey', 'depth' => 0, ), 2 => array ( 'id' => '2', 'property' => 'node:uid', 'operator' => '=', 'value' => '1', 'weight' => '2', 'theme' => 'garland', 'enabled' => '1', 'wildcards' => 'a:0:{}', 'parent' => '1', 'module' => 'themekey', 'depth' => 1, ), )	Debug	ThemekeyMultipleNodePropertiesTestCase.test	84	ThemekeyMultipleNodePropertiesTestCase->testMultipleProperties()

Themekey Node Properties (ThemekeyNodePropertiesTestCase) [Themekey]

190

Message	Group	Filename	Line	Function
Testing Rule: 'node:changed=1337846569'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:created=1337846569'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:language=neutral'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:nid=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:vid=2'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:promote=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:sticky=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:type=page'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:uid=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'node:title=Node title test'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()

Themekey System Properties (ThemekeySystemPropertiesTestCase) [Themekey]

Message	Group	Filename	Line	Function
Testing Rule: 'system:dummy=dummy'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'system:query_param=test=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()
Testing Rule: 'system:query_string=test=1'	Debug	themekey.test	30	ThemekeyWebTestCase->simplePropertyTest()

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

127 minor(s), 1 critical(s), and 2 normal(s)

Non-pass

Test name Minor Critical Normal

themekey_compat_admin.inc 0 1 0

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	themekey_compat_admin.inc	97	N/A

themekey_features.module 9 0 1

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	themekey_features.module	-1	N/A
There should be no trailing spaces	Other	themekey_features.module	92	N/A
There should be no trailing spaces	Other	themekey_features.module	112	N/A
There should be no trailing spaces	Other	themekey_features.module	114	N/A
There should be no trailing spaces	Other	themekey_features.module	125	N/A
There should be no trailing spaces	Other	themekey_features.module	176	N/A
There should be no trailing spaces	Other	themekey_features.module	180	N/A
There should be no trailing spaces	Other	themekey_features.module	212	N/A
There should be no trailing spaces	Other	themekey_features.module	215	N/A
There should be no trailing spaces	Other	themekey_features.module	231	N/A

themekey_ui.module 9 0 1

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	themekey_ui.module	250	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	themekey_ui.module	257	N/A
Missing parenthesis after function name	Other	themekey_ui.module	268	N/A
Format should be `* Implementation of hook_foo().`	Other	themekey_ui.module	268	N/A
Missing parenthesis after function name	Other	themekey_ui.module	304	N/A
Missing parenthesis after function name	Other	themekey_ui.module	321	N/A
Missing parenthesis after function name	Other	themekey_ui.module	358	N/A
Missing period	Other	themekey_ui.module	369	N/A
Missing period	Other	themekey_ui.module	415	N/A
Missing period	Other	themekey_ui.module	423	N/A

All

Test name Minor Critical Normal

docs/themekey.api.php 0 0 0

modules/themekey.blog.inc 2 0 0

Message	Group	Filename	Line	Function	Status
indent secondary line of comment one space	Other	themekey.blog.inc	67	N/A
indent secondary line of comment one space	Other	themekey.blog.inc	68	N/A

modules/themekey.book.inc 0 0 0

modules/themekey.comment.inc 0 0 0

modules/themekey.locale.inc 0 0 0

modules/themekey.node.inc 4 0 0

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	themekey.node.inc	220	N/A
Use an indent of 2 spaces, with no tabs	Other	themekey.node.inc	221	N/A
Use an indent of 2 spaces, with no tabs	Other	themekey.node.inc	222	N/A
Use an indent of 2 spaces, with no tabs	Other	themekey.node.inc	223	N/A

modules/themekey.og_context.inc 14 0 0

Message	Group	Filename	Line	Function
indent secondary line of comment one space	Other	themekey.og_context.inc	15	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	16	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	17	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	18	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	19	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	20	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	21	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	22	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	23	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	53	N/A
indent secondary line of comment one space	Other	themekey.og_context.inc	54	N/A
There should be no trailing spaces	Other	themekey.og_context.inc	57	N/A
There should be no trailing spaces	Other	themekey.og_context.inc	59	N/A
There should be no trailing spaces	Other	themekey.og_context.inc	83	N/A

modules/themekey.print.inc 0 0 0

modules/themekey.purl.inc 0 0 0

modules/themekey.revisioning.inc 0 0 0

modules/themekey.system.inc 13 0 0

Message	Group	Filename	Line	Function
indent secondary line of comment one space	Other	themekey.system.inc	688	N/A
indent secondary line of comment one space	Other	themekey.system.inc	689	N/A
indent secondary line of comment one space	Other	themekey.system.inc	690	N/A
indent secondary line of comment one space	Other	themekey.system.inc	691	N/A
indent secondary line of comment one space	Other	themekey.system.inc	692	N/A
indent secondary line of comment one space	Other	themekey.system.inc	693	N/A
indent secondary line of comment one space	Other	themekey.system.inc	694	N/A
indent secondary line of comment one space	Other	themekey.system.inc	695	N/A
indent secondary line of comment one space	Other	themekey.system.inc	696	N/A
indent secondary line of comment one space	Other	themekey.system.inc	697	N/A
indent secondary line of comment one space	Other	themekey.system.inc	698	N/A
indent secondary line of comment one space	Other	themekey.system.inc	699	N/A
indent secondary line of comment one space	Other	themekey.system.inc	700	N/A

modules/themekey.taxonomy.inc 0 0 0

modules/themekey.user.inc 0 0 0

modules/themekey.views.inc 1 0 0

Message	Group	Filename	Line	Function	Status
@file description should be on the following line (Drupal Docs)	Other	themekey.views.inc	4	N/A

modules/themekey_browser_detection.php 0 0 0

tests/themekey.test 0 0 0

tests/ThemekeyDrupalPropertiesTestCase.test 0 0 0

tests/ThemekeyMultipleNodePropertiesTestCase.test 0 0 0

tests/ThemekeyNodePropertiesTestCase.test 0 0 0

tests/ThemekeySystemPropertiesTestCase.test 2 0 0

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	ThemekeySystemPropertiesTestCase.test	30	N/A
There should be no trailing spaces	Other	ThemekeySystemPropertiesTestCase.test	42	N/A

themekey-debug-messages.tpl.php 0 0 0

themekey.install 2 0 0

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	themekey.install	410	N/A
There should be no trailing spaces	Other	themekey.install	560	N/A

themekey.module 3 0 0

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	themekey.module	136	N/A
indent secondary line of comment one space	Other	themekey.module	299	N/A
indent secondary line of comment one space	Other	themekey.module	300	N/A

themekey_admin.inc 2 0 0

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	themekey_admin.inc	72	N/A
There should be no trailing spaces	Other	themekey_admin.inc	188	N/A

themekey_base.inc 5 0 0

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	themekey_base.inc	66	N/A
There should be no trailing spaces	Other	themekey_base.inc	70	N/A
There should be no trailing spaces	Other	themekey_base.inc	91	N/A
There should be no trailing spaces	Other	themekey_base.inc	112	N/A
There should be no trailing spaces	Other	themekey_base.inc	120	N/A

themekey_build.inc 8 0 0

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	themekey_build.inc	288	N/A
There should be no trailing spaces	Other	themekey_build.inc	303	N/A
There should be no trailing spaces	Other	themekey_build.inc	341	N/A
There should be no trailing spaces	Other	themekey_build.inc	345	N/A
There should be no trailing spaces	Other	themekey_build.inc	357	N/A
There should be no trailing spaces	Other	themekey_build.inc	362	N/A
There should be no trailing spaces	Other	themekey_build.inc	385	N/A
There should be no trailing spaces	Other	themekey_build.inc	390	N/A

themekey_compat.install 0 0 0

themekey_compat.module 0 0 0

themekey_compat_admin.inc 0 1 0

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	themekey_compat_admin.inc	97	N/A

themekey_cron.inc 0 0 0

themekey_debug.install 0 0 0

themekey_debug.module 0 0 0

themekey_debug_admin.inc 0 0 0

themekey_example/themekey_example.module 0 0 0

themekey_example/themekey_example_mappers.inc 0 0 0

themekey_example/themekey_example_validators.inc 0 0 0

themekey_features.module 9 0 1

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	themekey_features.module	-1	N/A
There should be no trailing spaces	Other	themekey_features.module	92	N/A
There should be no trailing spaces	Other	themekey_features.module	112	N/A
There should be no trailing spaces	Other	themekey_features.module	114	N/A
There should be no trailing spaces	Other	themekey_features.module	125	N/A
There should be no trailing spaces	Other	themekey_features.module	176	N/A
There should be no trailing spaces	Other	themekey_features.module	180	N/A
There should be no trailing spaces	Other	themekey_features.module	212	N/A
There should be no trailing spaces	Other	themekey_features.module	215	N/A
There should be no trailing spaces	Other	themekey_features.module	231	N/A

themekey_help.inc 0 0 0

themekey_ui.install 0 0 0

themekey_ui.module 9 0 1

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	themekey_ui.module	250	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	themekey_ui.module	257	N/A
Missing parenthesis after function name	Other	themekey_ui.module	268	N/A
Format should be `* Implementation of hook_foo().`	Other	themekey_ui.module	268	N/A
Missing parenthesis after function name	Other	themekey_ui.module	304	N/A
Missing parenthesis after function name	Other	themekey_ui.module	321	N/A
Missing parenthesis after function name	Other	themekey_ui.module	358	N/A
Missing period	Other	themekey_ui.module	369	N/A
Missing period	Other	themekey_ui.module	415	N/A
Missing period	Other	themekey_ui.module	423	N/A

themekey_ui_admin.inc 1 0 0

Message	Group	Filename	Line	Function	Status
put a space between the asterisk and the comment text	Other	themekey_ui_admin.inc	193	N/A

themekey_ui_help.inc 0 0 0

themekey_ui_helper.inc 2 0 0

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	themekey_ui_helper.inc	44	N/A
There should be no trailing spaces	Other	themekey_ui_helper.inc	53	N/A

themekey_user_profile.install 0 0 0

themekey_user_profile.module 0 0 0

themekey_user_profile_help.inc 0 0 0

themekey_validators.inc 50 0 0

Message	Group	Filename	Line	Function
indent secondary line of comment one space	Other	themekey_validators.inc	833	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	834	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	835	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	836	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	837	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	838	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	839	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	840	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	841	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	842	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	843	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	844	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	845	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	846	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	847	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	848	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	849	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	850	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	851	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	852	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	853	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	854	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	855	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	856	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	857	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	882	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	883	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	884	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	885	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	886	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	887	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	888	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	889	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	890	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	891	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	892	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	893	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	894	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	895	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	896	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	897	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	898	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	899	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	900	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	901	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	902	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	903	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	904	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	905	N/A
indent secondary line of comment one space	Other	themekey_validators.inc	906	N/A

Review log