Forum Access - 6.x-1.x

Test status
StatusResult
Last receivedTue, 09/25/2012 - 09:14:06
Last requestedTue, 09/25/2012 - 09:15:02
Last testedTue, 09/25/2012 - 09:17:22
Test count13
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectForum Access
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 13 minor(s), 19 critical(s), and 14 normal(s); [[SimpleTest]]: [MySQL] 21,828 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
21,828 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafForum access functionality #3 (ForumAccessTestCase3) [Unknown]337100
LeafForum access functionality #4 (ForumAccessTestCase4) [Unknown]317500
LeafForum access functionality #5 (ForumAccessTestCase5) [Unknown]329000
LeafForum access functionality #6 (ForumAccessTestCase6) [Unknown]316600
LeafForum access functionality #7 (ForumAccessTestCase7) [Unknown]125900
LeafForumAccessTestCase1390100
LeafForumAccessTestCase2366600

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
13 minor(s), 19 critical(s), and 14 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandforum_access.admin.inc91712
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherforum_access.admin.inc4N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc58N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc65N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc66N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc67N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc68N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc69N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc70N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc71N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc72N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc80N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc112N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc237N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc245N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc302N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc304N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc310N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc311N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc313N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc314N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc316N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc318N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc319N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc321N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc322N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc323N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc372N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc402N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc618N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherforum_access.admin.inc658N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc712N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc789N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc803N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc809N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc817N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc874N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc903N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc916N/A
Expandforum_access.install001
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherforum_access.install187N/A
Expandforum_access.module221
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherforum_access.module4N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.module229N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.module229N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherforum_access.module374N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.module577N/A

All

Test nameMinorCriticalNormal
Expandforum_access.admin.inc91712
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherforum_access.admin.inc4N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc58N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc65N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc66N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc67N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc68N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc69N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc70N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc71N/A
Use an indent of 2 spaces, with no tabsOtherforum_access.admin.inc72N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc80N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc112N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc237N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc245N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc302N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc304N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc310N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc311N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc313N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc314N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc316N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc318N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc319N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc321N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc322N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc323N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc372N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc402N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc618N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherforum_access.admin.inc658N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc712N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc789N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.admin.inc803N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc809N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.admin.inc817N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc874N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc903N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherforum_access.admin.inc916N/A
Expandforum_access.install001
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherforum_access.install187N/A
Expandforum_access.module221
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherforum_access.module4N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherforum_access.module229N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.module229N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherforum_access.module374N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherforum_access.module577N/A
Expandforum_access.node.inc100
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherforum_access.node.inc4N/A
Expandforum_access.test100
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherforum_access.test1215N/A