User Points - 7.x-1.0

Test status
StatusResult
Last receivedSat, 09/08/2012 - 23:50:55
Last requestedSat, 09/08/2012 - 23:51:03
Last testedSat, 09/08/2012 - 23:53:17
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-1.0
ProjectUser Points
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 6 minor(s), 4 critical(s), and 21 normal(s); [[SimpleTest]]: [MySQL] 312 pass(es), 0 fail(s), and 22 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
312 pass(es), 0 fail(s), and 22 exception(s)

Non-pass

Test namePassFailException
ExpandServices integration (UserpointsServiceTestCase) [Userpoints]22022
MessageGroupFilenameLineFunctionStatus
Missing argument 5 for services_resource_build_index_query(), called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/userpoints/userpoints_service.inc on line 45 and definedWarningservices.module488services_resource_build_index_query()
Missing argument 6 for services_resource_build_index_query(), called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/userpoints/userpoints_service.inc on line 45 and definedWarningservices.module488services_resource_build_index_query()
Undefined variable: resourceNoticeservices.module489services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module490services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module493services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module493services_resource_build_index_query()
Undefined offset: 0Noticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()

All

Test namePassFailException
ExpandServices integration (UserpointsServiceTestCase) [Userpoints]22022
MessageGroupFilenameLineFunctionStatus
Missing argument 5 for services_resource_build_index_query(), called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/userpoints/userpoints_service.inc on line 45 and definedWarningservices.module488services_resource_build_index_query()
Missing argument 6 for services_resource_build_index_query(), called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/userpoints/userpoints_service.inc on line 45 and definedWarningservices.module488services_resource_build_index_query()
Undefined variable: resourceNoticeservices.module489services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module490services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module493services_resource_build_index_query()
Undefined variable: page_sizeNoticeservices.module493services_resource_build_index_query()
Undefined offset: 0Noticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test98UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test99UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 0Noticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test100UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Undefined offset: 1Noticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
Trying to get property of non-objectNoticeuserpoints_service.test101UserpointsServiceTestCase->testAddRetrievePoints()
LeafUserpoints Admin (UserpointsAdminTestCase) [Userpoints]4700
LeafUserpoints API (UserpointsAPITestCase) [Userpoints]24300

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
6 minor(s), 4 critical(s), and 21 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expanduserpoints.admin.inc041
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc30N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc40N/A
missing space after commaOtheruserpoints.admin.inc284N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc368N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc568N/A
Expanduserpoints.module1015
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints.module-1N/A
Use "elseif" in place of "else if"Otheruserpoints.module490N/A
missing space after commaOtheruserpoints.module492N/A
Use "elseif" in place of "else if"Otheruserpoints.module507N/A
missing space after commaOtheruserpoints.module509N/A
else statements should begin on a new lineOtheruserpoints.module1082N/A
Use "elseif" in place of "else if"Otheruserpoints.module1115N/A
Use "elseif" in place of "else if"Otheruserpoints.module1121N/A
Use "elseif" in place of "else if"Otheruserpoints.module1713N/A
else statements should begin on a new lineOtheruserpoints.module1787N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1892N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1895N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1898N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1899N/A
Use "elseif" in place of "else if"Otheruserpoints.module1966N/A
Use an indent of 2 spaces, with no tabsOtheruserpoints.module2082N/A
Expanduserpoints_service.inc201
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtheruserpoints_service.inc25N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtheruserpoints_service.inc31N/A
missing space after commaOtheruserpoints_service.inc94N/A
Expanduserpoints_service.module001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_service.module-1N/A
Expandviews/userpoints_views_handler_argument_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_argument_category.inc-1N/A
Expandviews/userpoints_views_handler_field_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_field_category.inc-1N/A
Expandviews/userpoints_views_handler_filter_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_filter_category.inc-1N/A

All

Test nameMinorCriticalNormal
Leaftests/userpoints_api.test000
Expanduserpoints.admin.inc041
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc30N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc40N/A
missing space after commaOtheruserpoints.admin.inc284N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc368N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheruserpoints.admin.inc568N/A
Expanduserpoints.api.php200
MessageGroupFilenameLineFunctionStatus
@see references should be separated by "," followed by a single space and with no trailing punctuationOtheruserpoints.api.php41N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtheruserpoints.api.php53N/A
Leafuserpoints.install000
Expanduserpoints.module1015
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints.module-1N/A
Use "elseif" in place of "else if"Otheruserpoints.module490N/A
missing space after commaOtheruserpoints.module492N/A
Use "elseif" in place of "else if"Otheruserpoints.module507N/A
missing space after commaOtheruserpoints.module509N/A
else statements should begin on a new lineOtheruserpoints.module1082N/A
Use "elseif" in place of "else if"Otheruserpoints.module1115N/A
Use "elseif" in place of "else if"Otheruserpoints.module1121N/A
Use "elseif" in place of "else if"Otheruserpoints.module1713N/A
else statements should begin on a new lineOtheruserpoints.module1787N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1892N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1895N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1898N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otheruserpoints.module1899N/A
Use "elseif" in place of "else if"Otheruserpoints.module1966N/A
Use an indent of 2 spaces, with no tabsOtheruserpoints.module2082N/A
Leafuserpoints.pages.inc000
Leafuserpoints.theme.inc000
Leafuserpoints.views.inc000
Leafuserpoints_rules.module000
Expanduserpoints_rules.rules.inc100
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtheruserpoints_rules.rules.inc37N/A
Expanduserpoints_service.inc201
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtheruserpoints_service.inc25N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtheruserpoints_service.inc31N/A
missing space after commaOtheruserpoints_service.inc94N/A
Expanduserpoints_service.module001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_service.module-1N/A
Leafuserpoints_service.test000
Expandviews/userpoints_views_handler_argument_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_argument_category.inc-1N/A
Expandviews/userpoints_views_handler_field_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_field_category.inc-1N/A
Expandviews/userpoints_views_handler_filter_category.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otheruserpoints_views_handler_filter_category.inc-1N/A