User points Nodes and Comments - 7.x-1.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

User points Nodes and Comments - 7.x-1.x

Test status

Status	Result
Last received	Wed, 04/11/2012 - 09:03:06
Last requested	Wed, 04/11/2012 - 09:04:00
Last tested	Wed, 04/11/2012 - 09:04:02
Test count	9

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.x
Project	User points Nodes and Comments
Link	Project information

Event logView entire log

ID	Message	Timestamp
3558594	Result retrieved by project client.	3 years 45 weeks ago
3558584	Result retrieved by project client.	3 years 45 weeks ago
3558559	Result retrieved by project client.	3 years 45 weeks ago
3558519	Result received from test client #.	3 years 45 weeks ago
3558514	Requested by test client #.	3 years 45 weeks ago
3558509	Result received from test client #.	3 years 45 weeks ago
3558484	Re-test request ignored because test is already queued.	3 years 45 weeks ago
3558439	Requested by test client #.	3 years 45 weeks ago
3558434	Test reset by client request.	3 years 45 weeks ago
3558429	Re-test request ignored because test is already queued.	3 years 45 weeks ago

SummaryPASSED: [[SimpleTest]]: [MySQL] 218 pass(es); [[Coder]]: [Code review] 7 minor(s), 2 critical(s), and 5 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

218 pass(es), 0 fail(s), and 0 exception(s)

Test name	Pass	Fail	Exception
Userpoints Node Visits (UserpointsNodeVisitsTestCase) [Userpoints]	138	0	0
Userpoints Nodes and Comments (UserpointsNodeCommentTestCase) [Userpoints]	80	0	0

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

7 minor(s), 2 critical(s), and 5 normal(s)

Non-pass

Test name

Minor

Critical

Normal

userpoints_nc.module

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	userpoints_nc.module	-1	N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	userpoints_nc.module	370	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	404	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	405	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	416	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	417	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	514	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	515	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	526	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	527	N/A

userpoints_nc_visits/userpoints_nc_visits.module

Message	Group	Filename	Line	Function	Status
table names should be enclosed in {curly_brackets}	Other	userpoints_nc_visits.module	92	N/A

All

Test name

Minor

Critical

Normal

userpoints_nc.install

userpoints_nc.module

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	userpoints_nc.module	-1	N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	userpoints_nc.module	370	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	404	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	405	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	416	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	417	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	514	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	515	N/A
Use "elseif" in place of "else if"	Other	userpoints_nc.module	526	N/A
Use an indent of 2 spaces, with no tabs	Other	userpoints_nc.module	527	N/A

userpoints_nc.test

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	userpoints_nc.test	42	N/A

userpoints_nc_revision/userpoints_nc_revision.module

userpoints_nc_visits/userpoints_nc_visits.install

userpoints_nc_visits/userpoints_nc_visits.module

Message	Group	Filename	Line	Function	Status
table names should be enclosed in {curly_brackets}	Other	userpoints_nc_visits.module	92	N/A

userpoints_nc_visits/userpoints_nc_visits.test

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	userpoints_nc_visits.test	6	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	userpoints_nc_visits.test	52	N/A

Review log