Webform - 7.x-4.x | Drupal Quality Assurance

Latest changes

Updated to PIFR 6.x-2.14-beta2. (New features!)

16 weeks 3 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

Client	Manager	Log
654	rfay	view log
659	rfay	view log
664	rfay	view log
813	rfay	view log
953	rfay	view log
958	rfay	view log
978	jthorson	view log
983	jthorson	view log
988	jthorson	view log
1148	rfay	view log
1153	rfay	view log
1158	rfay	view log
1163	rfay	view log
1168	rfay	view log
1173	rfay	view log
1178	rfay	view log
1183	rfay	view log
1188	rfay	view log
1193	rfay	view log

User login

Webform - 7.x-4.x

Test status

Status	Result
Last received	Sun, 07/29/2012 - 03:55:15
Last requested	Sun, 07/29/2012 - 03:58:54
Last tested	Sun, 07/29/2012 - 03:59:41
Test count	4

Environment status

MySQL	fail
Code review	fail

Overall Result	fail

Branch information

Identifier	7.x-4.x
Project	Webform
Link	Project information

Event logView entire log

ID	Message	Timestamp
4,066,323	Result retrieved by project client.	42 weeks 2 days ago
4,066,318	Result received from test client #654.	42 weeks 2 days ago
4,066,313	Requested by test client #654.	42 weeks 2 days ago
4,066,308	Result received from test client #654.	42 weeks 2 days ago
4,066,303	Requested by test client #654.	42 weeks 2 days ago
4,066,298	Test request received.	42 weeks 2 days ago
4,066,108	Result retrieved by project client.	42 weeks 2 days ago
4,066,103	Result received from test client #813.	42 weeks 2 days ago
4,066,098	Result received from test client #659.	42 weeks 2 days ago
4,066,083	Requested by test client #659.	42 weeks 2 days ago

SummaryFAILED: [[SimpleTest]]: [MySQL] 1,780 pass(es), 4 fail(s), and 0 exception(s); [[Coder]]: [Code review] 28 minor(s), 11 critical(s), and 29 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Review the test failures below then if necessary run them locally until the problem has been fixed.
Complete test suite with all tests passing

1,780 pass(es), 4 fail(s), and 0 exception(s)

Non-pass

Test name

Pass

Fail

Exception

Webform submission (WebformSubmissionTestCase) [Webform]

262

Message	Group	Filename	Line	Function
Component textfield_disabled data integrity check	Webform	submission.test	135	WebformSubmissionTestCase->webformSubmissionExecute()
Expected Array ( [0] => bar ) Recieved Array ( [0] => )	Webform	submission.test	137	WebformSubmissionTestCase->webformSubmissionExecute()
Component textfield_profile data integrity check	Webform	submission.test	135	WebformSubmissionTestCase->webformSubmissionExecute()
Expected Recieved Array ( [0] => )	Webform	submission.test	137	WebformSubmissionTestCase->webformSubmissionExecute()

All

Test name

Pass

Fail

Exception

Webform (WebformGeneralTestCase) [Webform]

Webform components (WebformComponentsTestCase) [Webform]

Webform conditionals (WebformConditionalsTestCase) [Webform]

1323

Webform permissions (WebformPermissionsTestCase) [Webform]

Webform submission (WebformSubmissionTestCase) [Webform]

262

Message	Group	Filename	Line	Function
Component textfield_disabled data integrity check	Webform	submission.test	135	WebformSubmissionTestCase->webformSubmissionExecute()
Expected Array ( [0] => bar ) Recieved Array ( [0] => )	Webform	submission.test	137	WebformSubmissionTestCase->webformSubmissionExecute()
Component textfield_profile data integrity check	Webform	submission.test	135	WebformSubmissionTestCase->webformSubmissionExecute()
Expected Recieved Array ( [0] => )	Webform	submission.test	137	WebformSubmissionTestCase->webformSubmissionExecute()

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

28 minor(s), 11 critical(s), and 29 normal(s)

Non-pass

Test name Minor Critical Normal

components/date.inc 0 2 0

Message	Group	Filename	Line	Function	Status
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	date.inc	280	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	date.inc	288	N/A

components/number.inc 4 0 10

Message	Group	Filename	Line	Function
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	223	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	281	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	292	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	number.inc	430	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	number.inc	467	N/A
missing space after comma	Other	number.inc	474	N/A
missing space after comma	Other	number.inc	475	N/A
missing space after comma	Other	number.inc	476	N/A
missing space after comma	Other	number.inc	477	N/A
missing space after comma	Other	number.inc	478	N/A
missing space after comma	Other	number.inc	479	N/A
missing space after comma	Other	number.inc	480	N/A
missing space after comma	Other	number.inc	481	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	713	N/A

includes/webform.components.inc 2 1 0

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.components.inc	300	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.components.inc	998	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.components.inc	1000	N/A

includes/webform.conditionals.inc 3 1 1

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.conditionals.inc	69	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	webform.conditionals.inc	194	N/A
Format should be `* Implementation of hook_foo().`	Other	webform.conditionals.inc	553	N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letter	Other	webform.conditionals.inc	553	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.conditionals.inc	956	N/A

includes/webform.emails.inc 0 1 0

Message	Group	Filename	Line	Function	Status
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.emails.inc	200	N/A

includes/webform.report.inc 0 0 2

Message	Group	Filename	Line	Function	Status
use a space between the closing parenthesis and the open bracket	Other	webform.report.inc	747	N/A
use a space between the closing parenthesis and the open bracket	Other	webform.report.inc	961	N/A

includes/webform.submissions.inc 0 3 0

Message	Group	Filename	Line	Function
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.submissions.inc	328	N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.submissions.inc	354	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.submissions.inc	383	N/A

templates/webform-mail.tpl.php 0 0 8

Message	Group	Filename	Line	Function
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	22	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	webform-mail.tpl.php	22	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	25	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	27	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	30	N/A
the final ?> should be omitted from all code files	Other	webform-mail.tpl.php	30	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	34	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	36	N/A

templates/webform-results-submissions.tpl.php 0 0 2

Message	Group	Filename	Line	Function	Status
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	webform-results-submissions.tpl.php	2	N/A
the final ?> should be omitted from all code files	Other	webform-results-submissions.tpl.php	30	N/A

templates/webform-submission-page.tpl.php 0 0 1

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	webform-submission-page.tpl.php	30	N/A

templates/webform-submission.tpl.php 0 0 1

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	webform-submission.tpl.php	17	N/A

webform.install 1 0 2

Message	Group	Filename	Line	Function
missing space after comma	Other	webform.install	809	N/A
Use update_sql() instead of db_query() in hook_update_N()	Other	webform.install	933	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.install	1258	N/A

webform.module 6 3 2

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	webform.module	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2475	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	webform.module	2476	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	webform.module	2481	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2719	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.module	2761	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2853	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2991	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	3106	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	webform.module	3120	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	3129	N/A

All

Test name Minor Critical Normal

components/date.inc 0 2 0

Message	Group	Filename	Line	Function	Status
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	date.inc	280	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	date.inc	288	N/A

components/email.inc 0 0 0

components/fieldset.inc 0 0 0

components/file.inc 0 0 0

components/grid.inc 0 0 0

components/hidden.inc 1 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	hidden.inc	141	N/A

components/markup.inc 0 0 0

components/number.inc 4 0 10

Message	Group	Filename	Line	Function
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	223	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	281	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	292	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	number.inc	430	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	number.inc	467	N/A
missing space after comma	Other	number.inc	474	N/A
missing space after comma	Other	number.inc	475	N/A
missing space after comma	Other	number.inc	476	N/A
missing space after comma	Other	number.inc	477	N/A
missing space after comma	Other	number.inc	478	N/A
missing space after comma	Other	number.inc	479	N/A
missing space after comma	Other	number.inc	480	N/A
missing space after comma	Other	number.inc	481	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	number.inc	713	N/A

components/pagebreak.inc 0 0 0

components/select.inc 1 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	select.inc	205	N/A

components/textarea.inc 0 0 0

components/textfield.inc 0 0 0

components/time.inc 0 0 0

includes/webform.admin.inc 0 0 0

includes/webform.components.inc 2 1 0

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.components.inc	300	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.components.inc	998	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.components.inc	1000	N/A

includes/webform.conditionals.inc 3 1 1

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.conditionals.inc	69	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	webform.conditionals.inc	194	N/A
Format should be `* Implementation of hook_foo().`	Other	webform.conditionals.inc	553	N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letter	Other	webform.conditionals.inc	553	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.conditionals.inc	956	N/A

includes/webform.emails.inc 0 1 0

Message	Group	Filename	Line	Function	Status
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.emails.inc	200	N/A

includes/webform.export.inc 0 0 0

includes/webform.options.inc 2 0 0

Message	Group	Filename	Line	Function	Status
Format should be `* Implementation of hook_foo().`	Other	webform.options.inc	9	N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letter	Other	webform.options.inc	9	N/A

includes/webform.pages.inc 0 0 0

includes/webform.report.inc 0 0 2

Message	Group	Filename	Line	Function	Status
use a space between the closing parenthesis and the open bracket	Other	webform.report.inc	747	N/A
use a space between the closing parenthesis and the open bracket	Other	webform.report.inc	961	N/A

includes/webform.submissions.inc 0 3 0

Message	Group	Filename	Line	Function
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.submissions.inc	328	N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	webform.submissions.inc	354	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.submissions.inc	383	N/A

templates/webform-calendar.tpl.php 0 0 0

templates/webform-confirmation.tpl.php 0 0 0

templates/webform-form.tpl.php 0 0 0

templates/webform-mail.tpl.php 0 0 8

Message	Group	Filename	Line	Function
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	22	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	webform-mail.tpl.php	22	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	25	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	27	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	30	N/A
the final ?> should be omitted from all code files	Other	webform-mail.tpl.php	30	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	34	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	webform-mail.tpl.php	36	N/A

templates/webform-results-submissions.tpl.php 0 0 2

Message	Group	Filename	Line	Function	Status
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	webform-results-submissions.tpl.php	2	N/A
the final ?> should be omitted from all code files	Other	webform-results-submissions.tpl.php	30	N/A

templates/webform-submission-information.tpl.php 0 0 0

templates/webform-submission-navigation.tpl.php 0 0 0

templates/webform-submission-page.tpl.php 0 0 1

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	webform-submission-page.tpl.php	30	N/A

templates/webform-submission.tpl.php 0 0 1

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	webform-submission.tpl.php	17	N/A

tests/components.test 0 0 0

tests/conditionals.test 0 0 0

tests/permissions.test 0 0 0

tests/submission.test 0 0 0

tests/webform.test 1 0 0

Message	Group	Filename	Line	Function	Status
use lowercase html tags to comply with XHTML	Other	webform.test	421	N/A

views/webform.views.inc 0 0 0

views/webform_handler_field_form_body.inc 0 0 0

views/webform_handler_field_is_draft.inc 0 0 0

views/webform_handler_field_node_link_edit.inc 0 0 0

views/webform_handler_field_node_link_results.inc 0 0 0

views/webform_handler_field_submission_count.inc 0 0 0

views/webform_handler_field_submission_link.inc 0 0 0

views/webform_handler_field_webform_status.inc 0 0 0

views/webform_handler_filter_is_draft.inc 0 0 0

views/webform_handler_filter_webform_status.inc 0 0 0

webform.api.php 6 0 0

Message	Group	Filename	Line	Function
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	webform.api.php	52	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.api.php	673	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.api.php	674	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.api.php	677	N/A
Format should be `* Implementation of hook_foo().`	Other	webform.api.php	704	N/A
Format should be `* Implementation of hook_foo().`	Other	webform.api.php	716	N/A

webform.install 1 0 2

Message	Group	Filename	Line	Function
missing space after comma	Other	webform.install	809	N/A
Use update_sql() instead of db_query() in hook_update_N()	Other	webform.install	933	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.install	1258	N/A

webform.module 6 3 2

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	webform.module	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2475	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	webform.module	2476	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	webform.module	2481	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2719	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	webform.module	2761	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2853	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	2991	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	3106	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	webform.module	3120	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.module	3129	N/A

webform.tokens.inc 1 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	webform.tokens.inc	121	N/A

Review log

Drupal Quality Assurance

Latest changes

Support

Additional info

Test client logs

User login

Webform - 7.x-4.x

MySQL

Non-pass

All

Code review

Non-pass

All