Home

IP Login - 7.x-3.x

Test status
StatusResult
Last receivedSat, 01/12/2013 - 08:13:11
Last requestedSat, 01/12/2013 - 08:14:04
Last testedSat, 01/12/2013 - 08:14:45
Test count4
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-3.x
ProjectIP Login
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 39 minor(s), 2 critical(s), and 27 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
39 minor(s), 2 critical(s), and 27 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandip_login.install25015
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherip_login.install17N/A
There should be no trailing spacesOtherip_login.install22N/A
There should be no trailing spacesOtherip_login.install27N/A
There should be no trailing spacesOtherip_login.install30N/A
There should be no trailing spacesOtherip_login.install41N/A
There should be no trailing spacesOtherip_login.install45N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install53N/A
There should be no trailing spacesOtherip_login.install54N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install55N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install57N/A
There should be no trailing spacesOtherip_login.install60N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install64N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install64N/A
There should be no trailing spacesOtherip_login.install68N/A
There should be no trailing spacesOtherip_login.install73N/A
There should be no trailing spacesOtherip_login.install76N/A
There should be no trailing spacesOtherip_login.install87N/A
There should be no trailing spacesOtherip_login.install93N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install104N/A
There should be no trailing spacesOtherip_login.install110N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install114N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install118N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install118N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install119N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install124N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install125N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install127N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install128N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install129N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install130N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install131N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install132N/A
else statements should begin on a new lineOtherip_login.install134N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install136N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install142N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install142N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherip_login.install143N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install144N/A
else statements should begin on a new lineOtherip_login.install144N/A
Expandip_login.module10212
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.module124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module130N/A
else statements should begin on a new lineOtherip_login.module130N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module134N/A
else statements should begin on a new lineOtherip_login.module134N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module143N/A
else statements should begin on a new lineOtherip_login.module143N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module147N/A
else statements should begin on a new lineOtherip_login.module147N/A
There should be no trailing spacesOtherip_login.module154N/A
Missing parenthesis after function nameOtherip_login.module203N/A
Missing parenthesis after function nameOtherip_login.module217N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module247N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module251N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module264N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module282N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module310N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module311N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Otherip_login.module325N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module393N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherip_login.module444N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module470N/A
Missing parenthesis after function nameOtherip_login.module487N/A

All

Test nameMinorCriticalNormal
Expandip_login.admin.inc200
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.admin.inc120N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.admin.inc121N/A
Expandip_login.install25015
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherip_login.install17N/A
There should be no trailing spacesOtherip_login.install22N/A
There should be no trailing spacesOtherip_login.install27N/A
There should be no trailing spacesOtherip_login.install30N/A
There should be no trailing spacesOtherip_login.install41N/A
There should be no trailing spacesOtherip_login.install45N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install53N/A
There should be no trailing spacesOtherip_login.install54N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install55N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install57N/A
There should be no trailing spacesOtherip_login.install60N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install64N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install64N/A
There should be no trailing spacesOtherip_login.install68N/A
There should be no trailing spacesOtherip_login.install73N/A
There should be no trailing spacesOtherip_login.install76N/A
There should be no trailing spacesOtherip_login.install87N/A
There should be no trailing spacesOtherip_login.install93N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install104N/A
There should be no trailing spacesOtherip_login.install110N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install114N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install118N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install118N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install119N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install124N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install125N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install127N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install128N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install129N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install130N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install131N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install132N/A
else statements should begin on a new lineOtherip_login.install134N/A
Use an indent of 2 spaces, with no tabsOtherip_login.install136N/A
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.install142N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install142N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherip_login.install143N/A
use a space between the closing parenthesis and the open bracketOtherip_login.install144N/A
else statements should begin on a new lineOtherip_login.install144N/A
Expandip_login.module10212
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherip_login.module124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module124N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module130N/A
else statements should begin on a new lineOtherip_login.module130N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module134N/A
else statements should begin on a new lineOtherip_login.module134N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module143N/A
else statements should begin on a new lineOtherip_login.module143N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module147N/A
else statements should begin on a new lineOtherip_login.module147N/A
There should be no trailing spacesOtherip_login.module154N/A
Missing parenthesis after function nameOtherip_login.module203N/A
Missing parenthesis after function nameOtherip_login.module217N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module247N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module251N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module264N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module282N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module310N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module311N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Otherip_login.module325N/A
use a space between the closing parenthesis and the open bracketOtherip_login.module393N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherip_login.module444N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherip_login.module470N/A
Missing parenthesis after function nameOtherip_login.module487N/A
Expandviews/ip_login.views_default.inc200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherip_login.views_default.inc23N/A
There should be no trailing spacesOtherip_login.views_default.inc192N/A