Home

JavaScript Libraries Manager - 7.x-1.x

Test status
StatusResult
Last receivedTue, 05/15/2012 - 22:16:08
Last requestedTue, 05/15/2012 - 22:22:21
Last testedTue, 05/15/2012 - 22:22:30
Test count8
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectJavaScript Libraries Manager
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 92 pass(es); [[Coder]]: [Code review] 9 minor(s), 1 critical(s), and 7 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
92 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
Leaftest for custom JS (JavaScriptLibrariesCustomTestCase) [JavaScript Libraries Manager]6500
Leaftest for Drupal JS (JavaScriptLibrariesDrupalTestCase) [JavaScript Libraries Manager]2700

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
9 minor(s), 1 critical(s), and 7 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandjavascript_libraries.admin.inc915
MessageGroupFilenameLineFunctionStatus
missing space after commaOtherjavascript_libraries.admin.inc16N/A
Control statements should have one space between the control keyword and opening parenthesisOtherjavascript_libraries.admin.inc63N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherjavascript_libraries.admin.inc71N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherjavascript_libraries.admin.inc71N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherjavascript_libraries.admin.inc98N/A
else statements should begin on a new lineOtherjavascript_libraries.admin.inc178N/A
missing space after commaOtherjavascript_libraries.admin.inc214N/A
Use an indent of 2 spaces, with no tabsOtherjavascript_libraries.admin.inc285N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherjavascript_libraries.admin.inc304N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherjavascript_libraries.admin.inc304N/A
use lowercase html tags to comply with XHTMLOtherjavascript_libraries.admin.inc456N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc498N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc523N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherjavascript_libraries.admin.inc544N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc559N/A
Expandjavascript_libraries.module001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherjavascript_libraries.module74N/A
Expandtests/javascript_libraries.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherjavascript_libraries.test-1N/A

All

Test nameMinorCriticalNormal
Expandjavascript_libraries.admin.inc915
MessageGroupFilenameLineFunctionStatus
missing space after commaOtherjavascript_libraries.admin.inc16N/A
Control statements should have one space between the control keyword and opening parenthesisOtherjavascript_libraries.admin.inc63N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherjavascript_libraries.admin.inc71N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherjavascript_libraries.admin.inc71N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherjavascript_libraries.admin.inc98N/A
else statements should begin on a new lineOtherjavascript_libraries.admin.inc178N/A
missing space after commaOtherjavascript_libraries.admin.inc214N/A
Use an indent of 2 spaces, with no tabsOtherjavascript_libraries.admin.inc285N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherjavascript_libraries.admin.inc304N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherjavascript_libraries.admin.inc304N/A
use lowercase html tags to comply with XHTMLOtherjavascript_libraries.admin.inc456N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc498N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc523N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherjavascript_libraries.admin.inc544N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherjavascript_libraries.admin.inc559N/A
Leafjavascript_libraries.api.php000
Leafjavascript_libraries.drush.inc000
Leafjavascript_libraries.install000
Expandjavascript_libraries.module001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherjavascript_libraries.module74N/A
Expandtests/javascript_libraries.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherjavascript_libraries.test-1N/A