Home

Simplenews Scheduler - 7.x-1.x

Test status
StatusResult
Last receivedSat, 10/27/2012 - 20:42:13
Last requestedSat, 10/27/2012 - 20:43:03
Last testedSat, 10/27/2012 - 20:44:57
Test count24
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectSimplenews Scheduler
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 16 minor(s), 3 critical(s), and 10 normal(s); [[SimpleTest]]: [MySQL] 3,373 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
3,373 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafDaylight Saving Time (SimpleNewsSchedulerDaylightSavingSwitchTest) [Simplenews Scheduler]200
LeafEdition due test (SimpleNewsSchedulerEditionDueTest) [Simplenews Scheduler]32800
LeafEdition time: monthly (SimpleNewsSchedulerEditionTimeTest) [Simplenews Scheduler]74400
LeafNewsletter generation test (SimpleNewsSchedulerNodeCreationTest) [Simplenews Scheduler]5800
LeafNext run time: monthly (SimpleNewsSchedulerNextRunTimeTest) [Simplenews Scheduler]224100

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
16 minor(s), 3 critical(s), and 10 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandsimplenews_scheduler.module121
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othersimplenews_scheduler.module309N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersimplenews_scheduler.module507N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Othersimplenews_scheduler.module508N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthersimplenews_scheduler.module643N/A
Expandsimplenews_scheduler_views.inc1319
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Othersimplenews_scheduler_views.inc4N/A
Missing parenthesis after function nameOthersimplenews_scheduler_views.inc9N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc31N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc33N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othersimplenews_scheduler_views.inc34N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc35N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthersimplenews_scheduler_views.inc36N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc38N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc39N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc40N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othersimplenews_scheduler_views.inc40N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc42N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc43N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc49N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc53N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc54N/A
missing space after commaOthersimplenews_scheduler_views.inc55N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc57N/A
missing space after commaOthersimplenews_scheduler_views.inc66N/A
use lowercase html tags to comply with XHTMLOthersimplenews_scheduler_views.inc66N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc71N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc72N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthersimplenews_scheduler_views.inc73N/A

All

Test nameMinorCriticalNormal
Leafsimplenews_scheduler.api.php000
Leafsimplenews_scheduler.install000
Expandsimplenews_scheduler.module121
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othersimplenews_scheduler.module309N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersimplenews_scheduler.module507N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Othersimplenews_scheduler.module508N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthersimplenews_scheduler.module643N/A
Expandsimplenews_scheduler_views.inc1319
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Othersimplenews_scheduler_views.inc4N/A
Missing parenthesis after function nameOthersimplenews_scheduler_views.inc9N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc31N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc33N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othersimplenews_scheduler_views.inc34N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc35N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthersimplenews_scheduler_views.inc36N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc38N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc39N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc40N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othersimplenews_scheduler_views.inc40N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc42N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc43N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc49N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc53N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc54N/A
missing space after commaOthersimplenews_scheduler_views.inc55N/A
There should be no trailing spacesOthersimplenews_scheduler_views.inc57N/A
missing space after commaOthersimplenews_scheduler_views.inc66N/A
use lowercase html tags to comply with XHTMLOthersimplenews_scheduler_views.inc66N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc71N/A
Control statements should have one space between the control keyword and opening parenthesisOthersimplenews_scheduler_views.inc72N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthersimplenews_scheduler_views.inc73N/A
Expandtests/simplenews_scheduler.test200
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Othersimplenews_scheduler.test505N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOthersimplenews_scheduler.test505N/A