Home

Fivestar - 7.x-2.x

Test status
StatusResult
Last receivedMon, 07/02/2012 - 13:34:15
Last requestedMon, 07/02/2012 - 13:35:02
Last testedMon, 07/02/2012 - 13:36:02
Test count43
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-2.x
ProjectFivestar
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 29 minor(s), 6 critical(s), and 22 normal(s); [[SimpleTest]]: [MySQL] 115 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
115 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafFivestar widgets (FivestarTestCase) [Fivestar]11500

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
29 minor(s), 6 critical(s), and 22 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandfivestar.install5013
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfivestar.install40N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install41N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install54N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install56N/A
There should be no trailing spacesOtherfivestar.install63N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.install80N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.install86N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install96N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install98N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install115N/A
There should be no trailing spacesOtherfivestar.install130N/A
There should be no trailing spacesOtherfivestar.install163N/A
There should be no trailing spacesOtherfivestar.install169N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install181N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install184N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install189N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install217N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install220N/A
Expandfivestar.module114
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfivestar.module181N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.module309N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.module316N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherfivestar.module691N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.module714N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.module720N/A
Expandincludes/fivestar.field.inc1954
MessageGroupFilenameLineFunctionStatus
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc67N/A
There should be no trailing spacesOtherfivestar.field.inc71N/A
There should be no trailing spacesOtherfivestar.field.inc88N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.field.inc134N/A
There should be no trailing spacesOtherfivestar.field.inc226N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc230N/A
There should be no trailing spacesOtherfivestar.field.inc234N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.field.inc249N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc255N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc258N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc267N/A
There should be no trailing spacesOtherfivestar.field.inc284N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherfivestar.field.inc286N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc287N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc294N/A
There should be no trailing spacesOtherfivestar.field.inc339N/A
There should be no trailing spacesOtherfivestar.field.inc355N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc418N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc420N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc421N/A
There should be no trailing spacesOtherfivestar.field.inc424N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc427N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc428N/A
Use an indent of 2 spaces, with no tabsOtherfivestar.field.inc550N/A
@see should always be at the beginning of a line, never inline in other comments.Otherfivestar.field.inc600N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherfivestar.field.inc600N/A
Use "elseif" in place of "else if"Otherfivestar.field.inc655N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc663N/A
Expandincludes/fivestar.theme.inc001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.theme.inc187N/A

All

Test nameMinorCriticalNormal
Leaffivestar.api.php000
Expandfivestar.install5013
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfivestar.install40N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install41N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install54N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install56N/A
There should be no trailing spacesOtherfivestar.install63N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.install80N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.install86N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install96N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install98N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install115N/A
There should be no trailing spacesOtherfivestar.install130N/A
There should be no trailing spacesOtherfivestar.install163N/A
There should be no trailing spacesOtherfivestar.install169N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install181N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install184N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install189N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install217N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.install220N/A
Expandfivestar.module114
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfivestar.module181N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.module309N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.module316N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherfivestar.module691N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.module714N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.module720N/A
Expandincludes/fivestar.admin.inc200
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherfivestar.admin.inc19N/A
Use an indent of 2 spaces, with no tabsOtherfivestar.admin.inc27N/A
Expandincludes/fivestar.field.inc1954
MessageGroupFilenameLineFunctionStatus
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc67N/A
There should be no trailing spacesOtherfivestar.field.inc71N/A
There should be no trailing spacesOtherfivestar.field.inc88N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherfivestar.field.inc134N/A
There should be no trailing spacesOtherfivestar.field.inc226N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc230N/A
There should be no trailing spacesOtherfivestar.field.inc234N/A
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.field.inc249N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc255N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc258N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc267N/A
There should be no trailing spacesOtherfivestar.field.inc284N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherfivestar.field.inc286N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc287N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfivestar.field.inc294N/A
There should be no trailing spacesOtherfivestar.field.inc339N/A
There should be no trailing spacesOtherfivestar.field.inc355N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc418N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc420N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc421N/A
There should be no trailing spacesOtherfivestar.field.inc424N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc427N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc428N/A
Use an indent of 2 spaces, with no tabsOtherfivestar.field.inc550N/A
@see should always be at the beginning of a line, never inline in other comments.Otherfivestar.field.inc600N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherfivestar.field.inc600N/A
Use "elseif" in place of "else if"Otherfivestar.field.inc655N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfivestar.field.inc663N/A
Expandincludes/fivestar.theme.inc001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherfivestar.theme.inc187N/A
Expandtest/fivestar.base.test200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfivestar.base.test15N/A
Use an indent of 2 spaces, with no tabsOtherfivestar.base.test22N/A
Leaftest/fivestar.field.test000